From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Mahapatra, Amit Kumar" <amit.kumar-mahapatra@amd.com>,
Conor Dooley <conor@kernel.org>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"git (AMD-Xilinx)" <git@amd.com>,
"amitrkcian2002@gmail.com" <amitrkcian2002@gmail.com>
Subject: Re: [PATCH v2] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems of resets for Cadence OSPI controller
Date: Mon, 26 May 2025 14:56:25 +0200 [thread overview]
Message-ID: <6b71bbef-84f6-4255-b8b2-cf50c5183235@kernel.org> (raw)
In-Reply-To: <IA0PR12MB769903933CC9200FD082143BDC65A@IA0PR12MB7699.namprd12.prod.outlook.com>
On 26/05/2025 09:07, Mahapatra, Amit Kumar wrote:
>>> - if:
>>> @@ -132,11 +139,11 @@ properties:
>>> maxItems: 1
>>>
>>> resets:
>>> - minItems: 2
>>> + minItems: 1
>>
>> I think you're still missing one of the things Krzysztof requested on v1, cos you
>> reduce minItems for all platforms without restricting it back to 2 for non-versal
>> platforms.
>
> I believe we can remove the "resets" and corresponding "reset-names"
> properties from here, as their default minItems/maxItems are already
> taken care of in the else block [1].
>
> [1] https://github.com/torvalds/linux/blob/0ff41df1cb268fc69e703a08a57ee14ae967d0ca/Documentation/devicetree/bindings/spi/cdns%2Cqspi-nor.yaml#L39
I don't see anything fixed there.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-26 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 10:47 [PATCH v2] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems of resets for Cadence OSPI controller Amit Kumar Mahapatra
2025-05-22 11:09 ` Mark Brown
2025-05-22 15:52 ` Conor Dooley
2025-05-26 7:07 ` Mahapatra, Amit Kumar
2025-05-26 12:56 ` Krzysztof Kozlowski [this message]
2025-05-27 6:05 ` Mahapatra, Amit Kumar
2025-05-27 6:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b71bbef-84f6-4255-b8b2-cf50c5183235@kernel.org \
--to=krzk@kernel.org \
--cc=amit.kumar-mahapatra@amd.com \
--cc=amitrkcian2002@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).