From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Richard Fitzgerald <rf@opensource.cirrus.com>, broonie@kernel.org
Cc: yung-chuan.liao@linux.intel.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH for-next 0/2] ASoC: Add Intel machine driver support for CS35L56 on SSP
Date: Mon, 24 Mar 2025 15:51:04 -0500 [thread overview]
Message-ID: <6b946a9c-8c62-44aa-8127-da06d23fbfaa@linux.dev> (raw)
In-Reply-To: <20250304145010.288082-1-rf@opensource.cirrus.com>
On 3/4/25 08:50, Richard Fitzgerald wrote:
> This adds support to the Intel machine drivers for CS35L56 codecs on
> Intel SSP port using TDM. Also adds the match entries for this on
> Tigerlake systems.
>
> Richard Fitzgerald (2):
> ASoC: Intel: Add sof_cs35l56 driver for CS35L56 on SSP2.
> ASoC: Intel: tgl-match: Add CS35L56 on SSP2 for CDB35L56-FOUR board
It'd be worth explaining why sof_ssp_amp.c is not good enough?
It's been used for CS35L41, what's different with the L56 that would require a new machine driver?
> MAINTAINERS | 1 +
> include/sound/soc-acpi-intel-ssp-common.h | 2 +
> sound/soc/intel/boards/Kconfig | 15 ++
> sound/soc/intel/boards/Makefile | 2 +
> sound/soc/intel/boards/sof_cs35l56.c | 254 ++++++++++++++++++
> .../intel/common/soc-acpi-intel-ssp-common.c | 1 +
> .../intel/common/soc-acpi-intel-tgl-match.c | 5 +
> 7 files changed, 280 insertions(+)
> create mode 100644 sound/soc/intel/boards/sof_cs35l56.c
>
prev parent reply other threads:[~2025-03-24 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 14:50 [PATCH for-next 0/2] ASoC: Add Intel machine driver support for CS35L56 on SSP Richard Fitzgerald
2025-03-04 14:50 ` [PATCH for-next 1/2] ASoC: Intel: Add sof_cs35l56 driver for CS35L56 on SSP2 Richard Fitzgerald
2025-03-04 14:50 ` [PATCH for-next 2/2] ASoC: Intel: tgl-match: Add CS35L56 on SSP2 for CDB35L56-FOUR board Richard Fitzgerald
2025-03-24 20:51 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b946a9c-8c62-44aa-8127-da06d23fbfaa@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox