The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Vinod <vkoul@kernel.org>
Cc: <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <lars@metafoo.de>,
	<radheys@xilinx.com>
Subject: Re: [PATCH v2 1/2] dmaengine: Add metadata_ops for dma_async_tx_descriptor
Date: Tue, 11 Sep 2018 15:33:51 +0300	[thread overview]
Message-ID: <6ba92876-899f-5bf2-e494-259e1e680750@ti.com> (raw)
In-Reply-To: <20180911073307.GK2634@vkoul-mobl>

Vinod,

On 2018-09-11 10:33, Vinod wrote:
>> +int dmaengine_desc_attach_metadata(struct dma_async_tx_descriptor *desc,
>> +				   void *data, size_t len)
>> +{
>> +	int ret;
>> +
>> +	if (!desc)
>> +		return -EINVAL;
>> +
>> +	ret = desc_check_and_set_metadata_mode(desc, DESC_METADATA_CLIENT);
>> +	if (ret)
>> +		return ret;
>> +
>> +	if (!desc->metadata_ops || !desc->metadata_ops->attach)
>> +		return -ENOTSUPP;
>> +
>> +	return desc->metadata_ops->attach(desc, data, len);
>> +}
>> +EXPORT_SYMBOL(dmaengine_desc_attach_metadata);
> 
> EXPORT_SYMBOL_GPL ?

Sure, I think I have looked at
dma_async_tx_descriptor_init/dmaengine_get_unmap_data/dma_issue_pending_all/etc
they have EXPORT_SYMBOL()

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2018-09-11 12:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 12:19 [PATCH v2 0/2] dmaengine: Add per descriptor metadata support Peter Ujfalusi
2018-08-30 12:19 ` [PATCH v2 1/2] dmaengine: Add metadata_ops for dma_async_tx_descriptor Peter Ujfalusi
2018-09-11  7:33   ` Vinod
2018-09-11 12:33     ` Peter Ujfalusi [this message]
2018-08-30 12:19 ` [PATCH v2 2/2] dmaengine: doc: Add sections for per descriptor metadata support Peter Ujfalusi
2018-09-11  7:36   ` Vinod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ba92876-899f-5bf2-e494-259e1e680750@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=radheys@xilinx.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox