public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "zhenglifeng (A)" <zhenglifeng1@huawei.com>
To: Pierre Gondois <pierre.gondois@arm.com>
Cc: <linux-kernel@vger.kernel.org>,
	Christian Loehle <christian.loehle@arm.com>,
	Ionela Voinescu <ionela.voinescu@arm.com>,
	Jie Zhan <zhanjie9@hisilicon.com>, Huang Rui <ray.huang@amd.com>,
	"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Perry Yuan <perry.yuan@amd.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	<linux-pm@vger.kernel.org>
Subject: Re: [PATCH v1 1/4] Revert "cpufreq: Fix re-boost issue after hotplugging a CPU"
Date: Thu, 4 Dec 2025 20:09:02 +0800	[thread overview]
Message-ID: <6bb8f60f-bbeb-42c7-ac18-e996db6379bd@huawei.com> (raw)
In-Reply-To: <20251204101344.192678-2-pierre.gondois@arm.com>

On 2025/12/4 18:13, Pierre Gondois wrote:
> policy->max_freq_req represents the maximum allowed frequency as
> requested by the policyX/scaling_max_freq sysfs file. This request
> applies to all CPUs of the policy. It is not possible to request
> a per-CPU maximum frequency.
> 
> Thus, the interaction between the policy boost and scaling_max_freq
> settings should be handled by adding a boost specific QoS constraint.
> This will be handled in the following patches.
> 
> This reverts commit 1608f0230510489d74a2e24e47054233b7e4678a.
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>  drivers/cpufreq/cpufreq.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 852e024facc3c..11b29c7dbea9e 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1478,10 +1478,6 @@ static int cpufreq_policy_online(struct cpufreq_policy *policy,
>  
>  		blocking_notifier_call_chain(&cpufreq_policy_notifier_list,
>  				CPUFREQ_CREATE_POLICY, policy);
> -	} else {
> -		ret = freq_qos_update_request(policy->max_freq_req, policy->max);
> -		if (ret < 0)
> -			goto out_destroy_policy;
>  	}
>  
>  	if (cpufreq_driver->get && has_target()) {

I don't think this commit should be reverted individually. These changes
can be included in patch 4, as they are doing the same thing if I
understand it correctly.


  reply	other threads:[~2025-12-04 12:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 10:13 [PATCH v1 0/4] cpufreq: Introduce boot frequency QoS Pierre Gondois
2025-12-04 10:13 ` [PATCH v1 1/4] Revert "cpufreq: Fix re-boost issue after hotplugging a CPU" Pierre Gondois
2025-12-04 12:09   ` zhenglifeng (A) [this message]
2025-12-08 10:24     ` Pierre Gondois
2025-12-04 10:13 ` [PATCH v1 2/4] cpufreq: Add boost_freq_req QoS request Pierre Gondois
2025-12-04 11:50   ` zhenglifeng (A)
2025-12-08 10:25     ` Pierre Gondois
2025-12-04 10:13 ` [PATCH v1 3/4] cpufreq: Centralize boost freq QoS requests Pierre Gondois
2025-12-04 12:02   ` zhenglifeng (A)
2025-12-08 10:24     ` Pierre Gondois
2025-12-04 10:13 ` [PATCH v1 4/4] cpufreq: Update set_boost callbacks to rely on boost_freq_req Pierre Gondois
2025-12-05 15:16   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bb8f60f-bbeb-42c7-ac18-e996db6379bd@huawei.com \
    --to=zhenglifeng1@huawei.com \
    --cc=christian.loehle@arm.com \
    --cc=gautham.shenoy@amd.com \
    --cc=ionela.voinescu@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=perry.yuan@amd.com \
    --cc=pierre.gondois@arm.com \
    --cc=rafael@kernel.org \
    --cc=ray.huang@amd.com \
    --cc=viresh.kumar@linaro.org \
    --cc=zhanjie9@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox