Re: [PATCH v2 2/5] dt-bindings: clock: Add i.MX91 clock definition

Krzysztof Kozlowski
2024-06-05T08:24:48Z

On 06/06/2024 02:23, Pengfei Li wrote:
> On Tue, Jun 04, 2024 at 10:04:47AM -0500, Rob Herring wrote:
>> On Wed, May 29, 2024 at 07:26:31PM -0700, Pengfei Li wrote:
>>> i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93.
>>> Add i.MX91 related clock definition.
>>>
>>> Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
>>> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>>> ---
>>> include/dt-bindings/clock/imx93-clock.h | 7 ++++++-
>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h
>>> index 787c9e74dc96..ca0785f35a46 100644
>>> --- a/include/dt-bindings/clock/imx93-clock.h
>>> +++ b/include/dt-bindings/clock/imx93-clock.h
>>> @@ -204,6 +204,11 @@
>>> #define IMX93_CLK_A55_SEL 199
>>> #define IMX93_CLK_A55_CORE 200
>>> #define IMX93_CLK_PDM_IPG 201
>>> -#define IMX93_CLK_END 202
>>> +#define IMX91_CLK_ENET1_QOS_TSN 202
>>> +#define IMX91_CLK_ENET_TIMER 203
>>> +#define IMX91_CLK_ENET2_REGULAR 204
>>> +#define IMX91_CLK_ENET2_REGULAR_GATE 205
>>> +#define IMX91_CLK_ENET1_QOS_TSN_GATE 206
>>> +#define IMX93_CLK_END 207
>>
>> Drop the END define. If it can change, it's not part of the ABI.
>>
>> Rob
>>
>
> Hi Rob Herring,
>
> The 'IMX93_CLK_END' macro definition is indeed not a certain clock, but it is
> used in the imx93 ccm driver to indicate the number of clocks. And this macro
> already existed before this patch, so it may not be able to be deleted.

May be. Trust me. Fix your driver first.

Best regards,
Krzysztof