Re: [PATCH v1 1/4] platform/x86: oxpec: Add support for OneXPlayer APEX

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]

On Wed, 18 Feb 2026, Antheas Kapenekakis wrote:

> This is a new Strix Halo handheld by OneXPlayer. Uses the same registers
> as the OneXPlayer Fly devices.

Hi,

The changelog bodies should be fully readable and understandable without 
the shortlog (in the Subject) so you cannot start with "This is ...".

The same problem was in some other patch of this series as well.

--
 i.

> Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
> ---
>  drivers/platform/x86/oxpec.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/oxpec.c b/drivers/platform/x86/oxpec.c
> index 144a454103b9..59d6f9d9a905 100644
> --- a/drivers/platform/x86/oxpec.c
> +++ b/drivers/platform/x86/oxpec.c
> @@ -11,7 +11,7 @@
>   *
>   * Copyright (C) 2022 Joaquín I. Aramendía <samsagax@gmail.com>
>   * Copyright (C) 2024 Derek J. Clark <derekjohn.clark@gmail.com>
> - * Copyright (C) 2025 Antheas Kapenekakis <lkml@antheas.dev>
> + * Copyright (C) 2025-2026 Antheas Kapenekakis <lkml@antheas.dev>
>   */
>  
>  #include <linux/acpi.h>
> @@ -142,6 +142,13 @@ static const struct dmi_system_id dmi_table[] = {
>  		},
>  		.driver_data = (void *)oxp_2,
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
> +			DMI_EXACT_MATCH(DMI_BOARD_NAME, "ONEXPLAYER APEX"),
> +		},
> +		.driver_data = (void *)oxp_fly,
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_VENDOR, "ONE-NETBOOK"),
>