From: Jens Axboe <axboe@kernel.dk>
To: "Joe Perches" <joe@perches.com>,
"Ed L. Cashin" <ed.cashin@acm.org>,
"Philipp Reisner" <philipp.reisner@linbit.com>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"Jiri Kosina" <jikos@kernel.org>,
"Josef Bacik" <josef@toxicpanda.com>,
linux-block@vger.kernel.org, "Ilya Dryomov" <idryomov@gmail.com>,
"Sage Weil" <sage@redhat.com>, "Alex Elder" <elder@kernel.org>,
"Joshua Morris" <josh.h.morris@us.ibm.com>,
"Philip Kelleher" <pjk1939@linux.vnet.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Juergen Gross" <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com,
nbd@other.debian.org, ceph-devel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] block drivers/block: Use octal not symbolic permissions
Date: Wed, 23 May 2018 15:27:11 -0600 [thread overview]
Message-ID: <6bf44255-145f-bf14-e254-860731ff9296@kernel.dk> (raw)
In-Reply-To: <5e97a292c1ba38a6b5a0caa271d85dc3de1b2aa7.1527105857.git.joe@perches.com>
On 5/23/18 2:05 PM, Joe Perches wrote:
> Convert the S_<FOO> symbolic permissions to their octal equivalents as
> using octal and not symbolic permissions is preferred by many as more
> readable.
>
> see: https://lkml.org/lkml/2016/8/2/1945
>
> Done with automated conversion via:
> $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace <files...>
>
> Miscellanea:
>
> o Wrapped modified multi-line calls to a single line where appropriate
> o Realign modified multi-line calls to open parenthesis
Honestly, I see this as pretty needless churn.
--
Jens Axboe
next prev parent reply other threads:[~2018-05-23 21:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 20:05 [PATCH] block drivers/block: Use octal not symbolic permissions Joe Perches
2018-05-23 21:27 ` Jens Axboe [this message]
2018-05-23 21:41 ` Joe Perches
2018-05-23 22:35 ` Joe Perches
2018-05-24 12:47 ` Jens Axboe
2018-05-24 13:01 ` Joe Perches
2018-05-24 19:40 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf44255-145f-bf14-e254-860731ff9296@kernel.dk \
--to=axboe@kernel.dk \
--cc=boris.ostrovsky@oracle.com \
--cc=ceph-devel@vger.kernel.org \
--cc=drbd-dev@lists.linbit.com \
--cc=ed.cashin@acm.org \
--cc=elder@kernel.org \
--cc=idryomov@gmail.com \
--cc=jasowang@redhat.com \
--cc=jgross@suse.com \
--cc=jikos@kernel.org \
--cc=joe@perches.com \
--cc=josef@toxicpanda.com \
--cc=josh.h.morris@us.ibm.com \
--cc=konrad.wilk@oracle.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nbd@other.debian.org \
--cc=philipp.reisner@linbit.com \
--cc=pjk1939@linux.vnet.ibm.com \
--cc=roger.pau@citrix.com \
--cc=sage@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox