Re: 2.6.15-rc1-mm2

[Michal Piotrowski <michal.k.k.piotrowski@gmail.com>]

Hi,

On 20/11/05, Hugh Dickins <hugh@veritas.com> wrote:
> On Sun, 20 Nov 2005, Michal Piotrowski wrote:
> >
> > It looks similar to Rafael J. Wysocki report. It's full reproductible
> > and appears when playing mp3's in totem.
> >
> > debian:/home/michal# cat /var/log/kern.log | grep -c "Bad page state
> > at free_hot_cold_page"
>
> Please let me know if it's not fixed by:
>
> --- 2.6.15-rc1-mm2/sound/core/memalloc.c        2005-11-12 09:01:28.000000000 +0000
> +++ linux/sound/core/memalloc.c 2005-11-19 19:03:32.000000000 +0000
> @@ -197,6 +197,7 @@ void *snd_malloc_pages(size_t size, gfp_
>
>         snd_assert(size > 0, return NULL);
>         snd_assert(gfp_flags != 0, return NULL);
> +       gfp_flags |= __GFP_COMP;        /* compound page lets parts be mapped */
>         pg = get_order(size);
>         if ((res = (void *) __get_free_pages(gfp_flags, pg)) != NULL) {
>                 mark_pages(virt_to_page(res), pg);
> @@ -241,6 +242,7 @@ static void *snd_malloc_dev_pages(struct
>         snd_assert(dma != NULL, return NULL);
>         pg = get_order(size);
>         gfp_flags = GFP_KERNEL
> +               | __GFP_COMP    /* compound page lets parts be mapped */
>                 | __GFP_NORETRY /* don't trigger OOM-killer */
>                 | __GFP_NOWARN; /* no stack trace print - this call is non-critical */
>         res = dma_alloc_coherent(dev, PAGE_SIZE << pg, dma, gfp_flags);
>

Patch has fixed problem. Thanks.

Regards,
Michal Piotrowski