Re: [PATCH RT] kstopmachine has legit preempt_enable_no_resched (was: 2.6.15-rt12 bugs)

[Michal Piotrowski <michal.k.k.piotrowski@gmail.com>]

Hi,

On 24/01/06, Steven Rostedt <rostedt@goodmis.org> wrote:
> Here Ingo,
>
> The kstop_machine has a legitimate preempt_enable_no_resched.
>
> -- Steve
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> Index: linux-2.6.15-rt12/kernel/stop_machine.c
> ===================================================================
> --- linux-2.6.15-rt12.orig/kernel/stop_machine.c        2006-01-23 09:15:37.000000000 -0500
> +++ linux-2.6.15-rt12/kernel/stop_machine.c     2006-01-23 19:58:26.000000000 -0500
> @@ -134,7 +134,7 @@
>  {
>         stopmachine_set_state(STOPMACHINE_EXIT);
>         raw_local_irq_enable();
> -       preempt_enable_no_resched();
> +       __preempt_enable_no_resched();
>  }
>
>  struct stop_machine_data
>
>
>

Great thanks!

Now 2.6.15-rt14 works fine (after disabling CONFIG_DEBUG_STACKOVERFLOW).

I have noticed only one warning
WARNING: softirq-tasklet/8 changed soft IRQ-flags.
 [<c0103b1b>] dump_stack+0x1b/0x1f (20)
 [<c0135218>] illegal_API_call+0x41/0x46 (20)
 [<c0135267>] local_irq_disable+0x1d/0x1f (8)
  [<f886dbd5>] skge_extirq+0x117/0x138 [skge] (32)
 [<c01202d5>] tasklet_action+0x8a/0xf1 (24)
  [<c01205c1>] ksoftirqd+0x10f/0x19e (32)
  [<c012d7ca>] kthread+0x7b/0xa9 (36)
 [<c01010c5>] kernel_thread_helper+0x5/0xb (1047875612)
---------------------------
| preempt count: 00000000 ]
| 0-level deep critical section nesting:
----------------------------------------

------------------------------
| showing all locks held by: |  (softirq-tasklet/8 [c18a97d0,  98]):
------------------------------

And problems while loading ipv6 module
Running ntpdate to synchronize clockCould not allocate 4 bytes percpu data
modprobe: FATAL: Error inserting ipv6
(/lib/modules/2.6.15-rt14/kernel/net/ipv6/ipv6.ko): Cannot allocate
memory

Could not allocate 4 bytes percpu data
modprobe: FATAL: Error inserting ipv6
(/lib/modules/2.6.15-rt14/kernel/net/ipv6/ipv6.ko): Cannot allocate
memory

Here is my dmesg:
http://www.stardust.webpages.pl/files/rt/2.6.15-rt14/rt-dmesg
Here is my config:
http://www.stardust.webpages.pl/files/rt/2.6.15-rt14/rt-config

Regards,
Michal Piotrowski