From: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
To: Yang Li <yang.lee@linux.alibaba.com>, <perex@perex.cz>
Cc: <tiwai@suse.com>, <lgirdwood@gmail.com>, <broonie@kernel.org>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] ASoC: codec: wcd938x: Fix NULL but dereferenced coccicheck error
Date: Wed, 16 Feb 2022 17:03:47 +0530 [thread overview]
Message-ID: <6c021509-e29f-2946-b411-64242535a370@quicinc.com> (raw)
In-Reply-To: <20220216021116.94384-1-yang.lee@linux.alibaba.com>
On 2/16/2022 7:41 AM, Yang Li wrote:
Thanks for Fix Yang!!!
We are going to post complete cleaned patch. Shall we ignore this patch
for now?
> Eliminate the following coccicheck warning:
> ./sound/soc/codecs/wcd938x.c:4210:21-24: ERROR: component is NULL but
> dereferenced.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 013cc2aea0f6 ("ASoC: codec: wcd938x: Add switch control for selecting CTIA/OMTP Headset")
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> sound/soc/codecs/wcd938x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
> index 2663fe0bf64f..c46c4bfd84f2 100644
> --- a/sound/soc/codecs/wcd938x.c
> +++ b/sound/soc/codecs/wcd938x.c
> @@ -4207,7 +4207,7 @@ static bool wcd938x_swap_gnd_mic(struct snd_soc_component *component, bool activ
> struct wcd938x_priv *wcd938x;
>
> if (!component) {
> - dev_err(component->dev, "%s component is NULL\n", __func__);
> + pr_err("The snd_soc_component is NULL\n");
> return false;
> }
>
prev parent reply other threads:[~2022-02-16 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 2:11 [PATCH -next] ASoC: codec: wcd938x: Fix NULL but dereferenced coccicheck error Yang Li
2022-02-16 11:33 ` Srinivasa Rao Mandadapu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c021509-e29f-2946-b411-64242535a370@quicinc.com \
--to=quic_srivasam@quicinc.com \
--cc=abaci@linux.alibaba.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox