From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14E5F38757F for ; Thu, 30 Apr 2026 20:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777579465; cv=none; b=YzkpXMygSgqwBqX/1aD20qMLZ5N6xXpvlhAMnke2XJhAz3o9vGDIj9sjZSPVckbIJQpq4qOZQrpn7gwPGGXCee+RYN6tg2jpJ1Mlj1pkWalpZOJLuGmkgfltkn1SFafSQTtFK7Ozz0X2ilUfpif4ZJI+n/LVpzisIly0eIUP87g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777579465; c=relaxed/simple; bh=bjg0jLvJ21ZMtw5VtGEoNnjlwyplDrWkboAuQnSfgWU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=WgqlnhWFcQJGPlQ4lLuI/5oIoE4PEYtY+2CcGisyQ7AEhpTWL9vGm37kiOGjdinkSe9x++/hu42C9atj0JDqh8p3HBE+asI/iRBe5XbaXPyyaGSSUJMx8Wrr3VfE4AEvLkiJee1meGNVwypTIlLVJTwTUB0uNn9sX+ATSt1n2SE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uRKHo4x8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uRKHo4x8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4527C2BCB4; Thu, 30 Apr 2026 20:04:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777579464; bh=bjg0jLvJ21ZMtw5VtGEoNnjlwyplDrWkboAuQnSfgWU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=uRKHo4x8xDxpQ3hiI9p4PUB/9C6mfRJc8R9kcLrmof++B3BchnuBfB4aGK2TGKm1f UnnZY7+mnQmIrbQYQw8uMNpihc2BvdADyRMRgmvejlwAItgz/SoprR3YkAnVZ/XArt dqopdqK5SiErts2wdoQAtNAfmDIkKojjKl1fJ8WQXb3oRipHj1gZ/r90kT1cz9qUub mpk6Y8YAb9f5ybEuUJK0k4uO/5m8Eudj9g1G8UxAXhb5HL0Q9lOLweIKUpAtdcT7Xx CRli+5PIHWfy13qJgFpJfmIMfRQGZsR8FsRsD1mbhYPjJYagjb69rp/wGO6LEk5i3e TRowJab+IOT+g== Date: Thu, 30 Apr 2026 14:04:20 -0600 (MDT) From: Paul Walmsley To: Zishun Yi cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Kees Cook , Will Pierce , Maxim Kochetkov , Samuel Holland , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Markus.Elfring@web.de, patchwork@lists.ozlabs.org Subject: Re: [PATCH] riscv: Check the return value of reloc handlers In-Reply-To: <20260321113419.34437-1-vulab@iscas.ac.cn> Message-ID: <6c1715e6-2bb9-40fd-dfb2-791468522614@kernel.org> References: <20260321113419.34437-1-vulab@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hello Zishun Yi (and, apparently, Wentao Liang), On Sat, 21 Mar 2026, Zishun Yi wrote: > Currently, process_accumulated_relocations() ignores the return values > from both reloc_handler() and accumulate_handler(). > > As a result, the kernel will proceed to load the module with corrupted > or incomplete sections, which can lead to unpredictable behavior or > kernel panics. > > So we need to check the return values of the handlers to propagate the > error, and fall back to the cleanup mode. > > Fixes: 8fd6c5142395 ("riscv: Add remaining module relocations") > Signed-off-by: Zishun Yi Thank you for sending this and several other fixes. I would like to accept the RISC-V-oriented fixes, but have a few questions first -- similar to the ones that Markus already asked you several weeks ago. First: were these fixes found and/or generated by LLM tools? They appear to be. If so, please add an Assisted-by: tag, according to the directions documented here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n637 and here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-assistants.rst Second: is it possible for you both to get your own unique E-mail accounts? Many kernel developers and tools assume that a specific E-mail address will be used by only one person. For example, Patchwork is now incorrectly attributing patches originally sent by Zishun Yi to Wentao Liang, under the not-unreasonable assumption that each developer will have their own E-mail address. - Paul