public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kuogee Hsieh <quic_khsieh@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 3/5] dt-bindings: display/msm: Document MDSS on QCS8300
Date: Fri, 19 Sep 2025 13:34:39 +0900	[thread overview]
Message-ID: <6c195b42-d994-4d24-9c40-48d8069304e3@kernel.org> (raw)
In-Reply-To: <b745c515-2264-42aa-8d92-663efc7f6276@oss.qualcomm.com>

On 18/09/2025 13:14, Yongxing Mou wrote:
> 
> 
> On 9/18/2025 9:01 AM, Krzysztof Kozlowski wrote:
>> On Thu, Sep 11, 2025 at 07:24:03PM +0800, Yongxing Mou wrote:
>>> Document the MDSS hardware found on the Qualcomm QCS8300 platform.
>>>
>>> Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
>>
>> Patch v11 and still basic issues. I am very dissapointed.
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions of patchset, under or above your Signed-off-by tag, unless
>> patch changed significantly (e.g. new properties added to the DT
>> bindings). Tag is "received", when provided in a message replied to you
>> on the mailing list. Tools like b4 can help here. However, there's no
>> need to repost patches *only* to add the tags. The upstream maintainer
>> will do that for tags received on the version they apply.
>>
>> Please read:
>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577
>>
>> If a tag was not added on purpose, please state why and what changed.
>> </form letter>
>>
>> Best regards,
>> Krzysztof
>>
> Hi,
> Sorry for the confusion. I did intend to remove the Reviewed-by tag, and 
> I mentioned this in the cover letter, but maybe explanation in 
> cover-letter was probe not clear at all.
> 
> This patch includes three changes:
> 
> 1.In the displayport-controller compatible property, "items" was changed 
> to "contains".
> 2.Use "qcom,sa8775p-dp" as fallback.
> 
> These changes might not be considered significant. So I’ll be more 
> careful next time. Thanks~


I really do not expect v12 to receive so significant changes in the
first place. If you keep sending us buggy code, which then you keep
changing after review, I will just not do the review. It's easier for me
to wait for v20...


Best regards,
Krzysztof

  reply	other threads:[~2025-09-19  4:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 11:24 [PATCH v12 0/5] Display enablement changes for Qualcomm QCS8300 platform Yongxing Mou
2025-09-11 11:24 ` [PATCH v12 1/5] dt-bindings: display/msm: Document the DPU for QCS8300 Yongxing Mou
2025-09-11 11:24 ` [PATCH v12 2/5] dt-bindings: display/msm: dp-controller: document QCS8300 compatible Yongxing Mou
2025-09-18  0:52   ` Krzysztof Kozlowski
2025-09-11 11:24 ` [PATCH v12 3/5] dt-bindings: display/msm: Document MDSS on QCS8300 Yongxing Mou
2025-09-18  1:01   ` Krzysztof Kozlowski
2025-09-18  4:14     ` Yongxing Mou
2025-09-19  4:34       ` Krzysztof Kozlowski [this message]
2025-09-26  9:17         ` Yongxing Mou
2025-09-26 23:26         ` Dmitry Baryshkov
2025-10-07  6:43           ` Krzysztof Kozlowski
2025-10-08 19:40             ` Dmitry Baryshkov
2025-10-27 11:52               ` Dmitry Baryshkov
2025-10-28  5:54                 ` Yongxing Mou
2025-09-11 11:24 ` [PATCH v12 4/5] soc: qcom: ubwc: Add QCS8300 UBWC cfg Yongxing Mou
2025-09-11 11:24 ` [PATCH v12 5/5] drm/msm: mdss: Add QCS8300 support Yongxing Mou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c195b42-d994-4d24-9c40-48d8069304e3@kernel.org \
    --to=krzk@kernel.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jessica.zhang@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_khsieh@quicinc.com \
    --cc=robh@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=yongxing.mou@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox