Re: [PATCH v12 00/13] HP BIOSCFG driver

Jorge Lopez
2023-05-08T21:03:01Z

Hi Thomas,

No problem at all. Any time you can provide me is greatly appreciated.
Thank you for letting me know.

Regards,

Jorge

On Mon, May 8, 2023 at 3:57 PM Thomas Weißschuh <thomas@t-8ch.de> wrote:
>
> Hi Jorge,
>
> On 2023-05-05 17:00:30-0500, Jorge Lopez wrote:
>
> <snip>
>
> > .../testing/sysfs-class-firmware-attributes | 117 ++-
> > MAINTAINERS | 6 +
> > drivers/platform/x86/hp/Kconfig | 16 +
> > drivers/platform/x86/hp/Makefile | 1 +
> > drivers/platform/x86/hp/hp-bioscfg/Makefile | 12 +
> > .../x86/hp/hp-bioscfg/biosattr-interface.c | 319 ++++++
> > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 982 ++++++++++++++++++
> > drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 523 ++++++++++
> > .../x86/hp/hp-bioscfg/enum-attributes.c | 482 +++++++++
> > .../x86/hp/hp-bioscfg/int-attributes.c | 448 ++++++++
> > .../x86/hp/hp-bioscfg/ordered-attributes.c | 443 ++++++++
> > .../x86/hp/hp-bioscfg/passwdobj-attributes.c | 584 +++++++++++
> > .../x86/hp/hp-bioscfg/spmobj-attributes.c | 381 +++++++
> > .../x86/hp/hp-bioscfg/string-attributes.c | 415 ++++++++
> > .../x86/hp/hp-bioscfg/surestart-attributes.c | 133 +++
> > 15 files changed, 4860 insertions(+), 2 deletions(-)
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/Makefile
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.h
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/int-attributes.c
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/ordered-attributes.c
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/string-attributes.c
> > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c
>
> Unfortunately I'm not sure I'll find enough time this week for a full
> review of this revision.
>
> I'll review bit by bit as time permits.
>
> Thomas