Re: [PATCH v12 00/13] HP BIOSCFG driver

Jorge Lopez
2023-05-08T20:49:14Z

On Mon, May 8, 2023 at 3:42 PM Thomas Weißschuh <thomas@t-8ch.de> wrote:
>
> On 2023-05-08 09:05:22-0500, Jorge Lopez wrote:
> > On Sat, May 6, 2023 at 1:57 AM Thomas Weißschuh <thomas@t-8ch.de> wrote:
> > >
> > > On 2023-05-05 17:00:30-0500, Jorge Lopez wrote:
> > > <snip>
> > >
> > > > Jorge Lopez (13):
> > > > HP BIOSCFG driver - Documentation
> > > > HP BIOSCFG driver - biosattr-interface
> > > > HP BIOSCFG driver - bioscfg
> > > > HP BIOSCFG driver - int-attributes
> > > > HP BIOSCFG driver - ordered-attributes
> > > > HP BIOSCFG driver - passwdobj-attributes
> > > > HP BIOSCFG driver - string-attributes
> > > > HP BIOSCFG driver - bioscfg-h
> > > > HP BIOSCFG driver - enum-attributes
> > > > HP BIOSCFG driver - spmobj-attributes
> > > > HP BIOSCFG driver - surestart-attributes
> > > > HP BIOSCFG driver - Makefile
> > > > HP BIOSCFG driver - MAINTAINERS
> > >
> > > These could be reordered a bit to be easier to read.
> > >
> > > * Documentation
> > > * bioscfg-h
> > > * bioscfg
> > > * biosattr-interface
> > > * *-attributes
> > > * Makefile
> > > * MAINTAINERS
> > >
> >
> > the order is determined when a particular commit took place and as
> > reported by git.
> > I will reorder the list in the cover-letter in future submissions.
>
> The commits should be ordered in a way that make the most sense.
> This should indeed match the order of commits/patches, you could reorder
> the commits to match the proposed order.
>

Thank you. Will do.

> > > Also currently the subject spacing is currently inconsistent.
> > > Something like "hp-bioscfg: foo" would be more in line with the rest of
> > > the kernel.
> > >
> >
> > Noted. I will update the subject spacing as indicated. "hp-bioscfg: foo"
> >
> > > >
> > > > .../testing/sysfs-class-firmware-attributes | 117 ++-
> > > > MAINTAINERS | 6 +
> > > > drivers/platform/x86/hp/Kconfig | 16 +
> > > > drivers/platform/x86/hp/Makefile | 1 +
> > > > drivers/platform/x86/hp/hp-bioscfg/Makefile | 12 +
> > > > .../x86/hp/hp-bioscfg/biosattr-interface.c | 319 ++++++
> > > > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 982 ++++++++++++++++++
> > > > drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 523 ++++++++++
> > > > .../x86/hp/hp-bioscfg/enum-attributes.c | 482 +++++++++
> > > > .../x86/hp/hp-bioscfg/int-attributes.c | 448 ++++++++
> > > > .../x86/hp/hp-bioscfg/ordered-attributes.c | 443 ++++++++
> > > > .../x86/hp/hp-bioscfg/passwdobj-attributes.c | 584 +++++++++++
> > > > .../x86/hp/hp-bioscfg/spmobj-attributes.c | 381 +++++++
> > > > .../x86/hp/hp-bioscfg/string-attributes.c | 415 ++++++++
> > > > .../x86/hp/hp-bioscfg/surestart-attributes.c | 133 +++
> > > > 15 files changed, 4860 insertions(+), 2 deletions(-)
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/Makefile
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.h
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/int-attributes.c
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/ordered-attributes.c
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/string-attributes.c
> > > > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c
> > > >
> > > > --
> > > > 2.34.1
> > > >