* [PATCH] bus: vexpress-config: fix device node reference leak in vexpress_syscfg_probe
@ 2025-09-02 8:19 Miaoqian Lin
2025-09-02 8:35 ` Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2025-09-02 8:19 UTC (permalink / raw)
To: Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi, Miaoqian Lin,
Rob Herring, linux-arm-kernel, linux-kernel
Cc: stable
Add missing of_node_put() call to release
the device node reference obtained via of_parse_phandle().
Since we don't actually use the node, decrement the
reference count immediately after obtaining it.
Fixes: a5a38765ac79 ("bus: vexpress-config: simplify config bus probing")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/bus/vexpress-config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index 64ee920721ee..aa17f819dfc9 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -393,6 +393,7 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
struct device_node *bridge_np;
bridge_np = of_parse_phandle(node, "arm,vexpress,config-bridge", 0);
+ of_node_put(bridge_np);
if (bridge_np != pdev->dev.parent->of_node)
continue;
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bus: vexpress-config: fix device node reference leak in vexpress_syscfg_probe
2025-09-02 8:19 [PATCH] bus: vexpress-config: fix device node reference leak in vexpress_syscfg_probe Miaoqian Lin
@ 2025-09-02 8:35 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2025-09-02 8:35 UTC (permalink / raw)
To: Miaoqian Lin, linux-arm-kernel
Cc: stable, LKML, Liviu Dudau, Lorenzo Pieralisi, Rob Herring,
Sudeep Holla
> Add missing of_node_put() call to release
> the device node reference obtained via of_parse_phandle().
…
You may occasionally put more than 58 characters into text lines
of such a change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n638
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-02 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-02 8:19 [PATCH] bus: vexpress-config: fix device node reference leak in vexpress_syscfg_probe Miaoqian Lin
2025-09-02 8:35 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).