From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00B0B202F91 for ; Fri, 18 Oct 2024 20:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729283338; cv=none; b=iBUjgGke2Y+DOYpn2uBIrGDYdXHVWxthN30b2i+axcymqRgD8lxLz0+BFPBvP3S4uvZcv2/zufqiCNjt9Q6mKBf/bDe6EpxpMsoQKvvhfL1oJlRFPVRKNzPJTJ68ec/eaM9wB4Oby0BGD85UaOzA9gAfOaAqZiFKEU4FCWfrzuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729283338; c=relaxed/simple; bh=wqiuD1vh/FuZqOOmwY/4qml0aFB+KWxNRCvJRKHqsKE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ujxbTnK5LzFUJpp4UAbGG4tJOqZHs/MEOe4odFLk29EM2k2mQEmuk5G8XjrvOU+nHv2BlKIfEnmcSph8BV7sjR2O9zSb95lJ7KGWPw4hZ7pV6PEaPTNrgip2KYdW93KitEo5sses6HaELbtCMFXQHQCUPqjs1L6jDtqfURTZf7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Rh3TrejE; arc=none smtp.client-ip=209.85.166.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Rh3TrejE" Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-83aac75fcceso103089039f.0 for ; Fri, 18 Oct 2024 13:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1729283336; x=1729888136; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HEIxT3pzjyKiKOABBKcn+MsmKD+aZXCEjCwEplxkrC4=; b=Rh3TrejEQ7yarZAfMleS9ihjBsfZhfAeqxeNPYZPGDa5L46T4heN7s7Kaptiu4Xx6r MpNfzPDm3AHeI0QAWnN4c3YT4757FRHQxa6aNTDgh6xDULK7FwbsP3+/AzLoQdgYsk8g i1xap+zjXVG9X5S81pVlnEEtI4FwY6P0jrgUc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729283336; x=1729888136; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HEIxT3pzjyKiKOABBKcn+MsmKD+aZXCEjCwEplxkrC4=; b=grNaJ8xfNWK+XbFpAJ+/UNLl88NxdrdEgwx5yT45+OtvcHZ+Tne0JVJowNPNkJDCN6 hjbNP68ft9gyQDUSs+CIgiwqnSsYHHLO1opH8EoPgj8NgsSz+2MTnYOQcQGwUDAJjyWb Ie7IDTW0kmPQTiitPqFznMivhdhiwkoPigKeRrXVFRxiogRCcXC5bb22VDdvw7Ocalbd mMJB3KvAY/C71CWNashGTYnRPsc4azG6bS7ldUtfkla9JjJn5Y0f9yi7GNeP9Gxox8rd QtW7Obm7aCU2bzZU0Y5jZEM31+whDDAtcgm1ZtYNGI6+4X31KafGxFLQh3a5ebsusw+I hgzA== X-Forwarded-Encrypted: i=1; AJvYcCW/P2qEKeX/qy+2SyW/ON+zRaTH9cNEBG/1mWsKh5zHmTEOdWi1ZsqsoQddEtubD7K0KpHZtGi1m7gGAIQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9EvZDVAvPLlyFMxm9cklso0se3g5Rd1lCGKmA9T1GjImaeDIU 03vCxYhDZ9vfz1D8P7Xahm+wvRzvor/n/vI5RdmGs1zYY6/eRNZ+O41gmSr13f8= X-Google-Smtp-Source: AGHT+IEmNTlbTxL/CzSKbj6Z1Ayoclfp2LZg5Ml5s5uZ6FaqD2hmPUC5+ArYCuRJH83neks98+42+g== X-Received: by 2002:a05:6602:3fcb:b0:83a:b3f8:e517 with SMTP id ca18e2360f4ac-83aba2f3b7bmr370716439f.0.1729283335889; Fri, 18 Oct 2024 13:28:55 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-83ab9d80c17sm57750739f.6.2024.10.18.13.28.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Oct 2024 13:28:55 -0700 (PDT) Message-ID: <6c9796ff-ccf8-404b-917f-57b48b42f6d6@linuxfoundation.org> Date: Fri, 18 Oct 2024 14:28:54 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] selftests/mseal: add more tests for mmap To: Lorenzo Stoakes , Jeff Xu Cc: Mark Brown , Muhammad Usama Anjum , akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, pedro.falcato@gmail.com, willy@infradead.org, vbabka@suse.cz, Liam.Howlett@oracle.com, rientjes@google.com, keescook@chromium.org, Shuah Khan References: <1f8eff74-005b-4fa9-9446-47f4cdbf3e8d@sirena.org.uk> <736fefd9-4bce-4aec-a492-2267fdc83776@lucifer.local> Content-Language: en-US From: Shuah Khan In-Reply-To: <736fefd9-4bce-4aec-a492-2267fdc83776@lucifer.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/18/24 13:52, Lorenzo Stoakes wrote: > On Fri, Oct 18, 2024 at 12:32:37PM -0700, Jeff Xu wrote: >>> when they encouter a failure, the pattern I sketched in my earlier >>> message, or switch to kselftest_harness.h (like I say I don't know if >>> the fork()ing is an issue for these tests). If I had to have a macro >>> it'd probably be something like mseal_assert(). >>> >> I can go with mseal_assert, the original macro is used by mseal_test >> itself, and only intended as such. >> >> If changing name to mseal_assert() is acceptable, this seems to be a >> minimum change and I'm happy with that. > > No. > Jeff, Please pay attention to the feedback you have been receiving so far from Mark and others about using the existing kselftest framework for reporting results and don't reinvent wheel. We have two frameworks to choose from - they both have been in use for quiet sometime by tests. If there is a need to add new functions and fix the existing ones that should happen in kselftest_harness.h or kselftest.h. We keep fixing problem and enhancing them as needed. With my kselfest and framework maintainer hat on, I don't want to see yet another framework emerging which is buried in tests. thanks, -- Shuah