From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16204F4FA for ; Sun, 13 Jul 2025 09:12:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752397970; cv=none; b=UX4E9wukBDYGF0wG2i+vjlPvk8KBVaW2mQ1OOE3xZ5gmOY2EaZX7xdBAGUlp+W7T6QKEKhrMAjABVP1SK1YMiP+UtJ0ew6zp2iUIMztwh/9YOuEVLueyjHrFxP1441rb/xh9SYNyJY6zgyhXoNCYUVcujwOitzUIXpVmtriJaf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752397970; c=relaxed/simple; bh=ttP2+H/bej+IM7hX8rbyBToQUHpPpcZy6rtLIIOb6c0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i8+nZk9e8TM/zrf3Jr6QqC+GVHz0xa2GEmSrdiLcov+L8CYjf5Ecq3N8jVU/zTiYGnHj0pP2KhJ8HTy2cCXDqSyFZ0TV+LvB300fo8LuYmrBjeR8ItzVmhjDNzC3GkxGe/h3fY8jU9bKTbwSKAtEgqX8YU0okXZEYmWGwncPg74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hRg1H883; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hRg1H883" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-4538bc52a8dso23565445e9.2 for ; Sun, 13 Jul 2025 02:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752397967; x=1753002767; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2bZfg9DF5nDVKhJoydkljHjxo8IZW88WiR/LfC60k7Y=; b=hRg1H883qwLMSTjeEigBOEFhVD6QoGYt4zn8ehVVliF72zunVAlKF6WNNtBtgsOkjo yeWypeD88AfwA0risdqQDYOTXkWQtUEI9wgSRcPWRTTeC1BDJzzxqhGjuU9Z6nnO12Th JO0qvtjoh9undSE6DPYmGfRWpxzu1IdfljeRwn2if4+TgwT1cD8tPGYIGCSebmwD5r/d 3+oEqg0jYBrlmBwBR5I2hK4Pqr1ynD5FfMPE7/ElU5olYtwPe7GE2og0ReNSy//+d5/N p9Hum00PCC1Sso5SS0NksWNep0lqBFuCcdpvC4NT8J51UWaugcDVmKOIBPdj/VdWsR50 CdlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752397967; x=1753002767; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2bZfg9DF5nDVKhJoydkljHjxo8IZW88WiR/LfC60k7Y=; b=g3hkSMZnXJycl4pZeOVNRl+ismRIJTuRhhYTqduMBa6nsqriBMJnHdppz7mcSZFiae 8RVDLCII3R3pqvdMvxJo+2/HD37NFcYkMp5ynys9C2bw20V6fQowsZEtAd/4a2UmjxZQ xSDl9fDQS1ARnYao32VSCSQ3xWBEFfSZxzn6I2LE/UuMNKPFBb8dMK3qlJobYVL96gY8 oa1iz06R+/2bV/Ng3YKsE667FZUeSnNplxvKPP0csa0h8ArLfrq9CLDvgcC/GkqyJs0+ N7AffJBITGUE+9Dn9nD/LsEiRCjIxDcTYF8EiM/keNAoAZVdGYpo73lpbkYT4mTizKrG lzQA== X-Forwarded-Encrypted: i=1; AJvYcCUn73kLAT+DTm1Z9VazRq+rdKo9PIvkVx2fAQQM54WgWjjZAYXZ7/zqUkte7nwKO8P/+ucYcN69mmJHJCg=@vger.kernel.org X-Gm-Message-State: AOJu0YwMnldiSgiGN54jVQwVdnpfN7hcYxN3vXVqBEeQdZuoEKIWotHA pkzXpNu6uA4r2gwvhLwphjxBVAkRrleUTIQTi0+nosUExujjOcJ51Rds2nYRPDH3Mvs= X-Gm-Gg: ASbGnctxg8mYM3LkV+rqhln3okYhaZ1m0CQb9MZAeQsnjh/48GL3FnaDqJfeTV0/R/r +2IkpFc87L7sdFMC3GIiEsVUK7fFDnv/QzXb1SZEFP2U6Pqjp58IvS0hvP5l41s8P6CGIo3lCj7 a9aJEgm5NwhdmqQR0R5yaGxi4s6QXiydBoT3PmjsipgzsqDKMcFGOLuAyQszfs+eVmXwfUs/3LE RBRZCbub9/pu8wiyLt1YDfyrWanlFhI2ozY+xJZRMxCI3N6+O8UvLkTs3nHv900039HNVIOICQb 0cx7/ke1AgxfTz0KjrcoNid7x8Mn7GKDbnQqTOjHT30hkpoxjih5MsYRcFiANH1oUHv1Zo7tGed syH72nUjWy7jaSk9XFi3g24nccVmSSWUtUUQXctLhiUtrmsjMlztrH298EOKtEF4= X-Google-Smtp-Source: AGHT+IFYMtWgYdOmndlZ3GtfdgwsQKMDhvhnsOVqQJrHIBGY5YzlakXukB0kQt0B+MV4iFsnSxY0lA== X-Received: by 2002:a05:600c:1f8d:b0:442:e9eb:1b48 with SMTP id 5b1f17b1804b1-454f42692d9mr74678445e9.24.1752397967443; Sun, 13 Jul 2025 02:12:47 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc9268sm9235312f8f.41.2025.07.13.02.12.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Jul 2025 02:12:46 -0700 (PDT) Message-ID: <6ca1b24b-5f9d-48e7-9afd-7dac47b486b1@linaro.org> Date: Sun, 13 Jul 2025 10:12:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 01/15] dt-bindings: media: qcom,x1e80100-camss: Assign correct main register bank to first address To: Krzysztof Kozlowski , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20250711-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-0-0bc5da82f526@linaro.org> <20250711-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-1-0bc5da82f526@linaro.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/07/2025 09:15, Krzysztof Kozlowski wrote: > On 11/07/2025 14:57, Bryan O'Donoghue wrote: >> The first register bank should be the 'main' register bank, in this case >> the CSID wrapper register is responsible for muxing PHY/TPG inputs directly >> to CSID or to other blocks such as the Sensor Front End. >> >> commit f4792eeaa971 ("dt-bindings: media: qcom,x1e80100-camss: Fix isp unit address") > > I have next from few days ago and I don't have this commit. https://gitlab.freedesktop.org/linux-media/media-committers/-/commit/1da245b6b73436be0d9936bb472f8a55900193cb >> assigned the address to the first register bank "csid0" whereas what we >> should have done is retained the unit address and moved csid_wrapper to be >> the first listed bank. > > This is confusing. Did that commit change entries in the binding? Fixed the unit address. What we _should_ have done is put csid_wrapper as the first entry. > >> >> Signed-off-by: Bryan O'Donoghue >> --- >> .../devicetree/bindings/media/qcom,x1e80100-camss.yaml | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml >> index b075341caafc1612e4faa3b7c1d0766e16646f7b..2438e08b894f4a3dc577cee4ab85184a3d7232b0 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml >> @@ -21,12 +21,12 @@ properties: >> >> reg-names: >> items: >> + - const: csid_wrapper > > Anyway, this is ABI break, so needs some sort of explanation in the > commit msg. We don't break ABI for cleanup reasons, unless it wasn't > released yet etc. So I since we haven't added the node to a dts yet which to my understanding means no ABI break. --- bod