Re: [PATCH 3/4] dt-bindings: regulator: Add bindings for MT6332 regulator

Krzysztof Kozlowski
2022-05-21T14:41:26Z

On 20/05/2022 15:33, AngeloGioacchino Del Regno wrote:
> Add devicetree bindings for the regulators found in the MT6332 PMIC.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> .../bindings/regulator/mt6332-regulator.yaml | 111 ++++++++++++++++++
> 1 file changed, 111 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mt6332-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/mt6332-regulator.yaml b/Documentation/devicetree/bindings/regulator/mt6332-regulator.yaml
> new file mode 100644
> index 000000000000..51077a865dbe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mt6332-regulator.yaml

Same comments as your other patch,

> @@ -0,0 +1,111 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mt6332-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MT6332 Regulator from MediaTek Integrated
> +
> +maintainers:
> + - AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> +
> +description: |
> + List of regulators provided by this controller. It is named

Best regards,
Krzysztof