From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E59C1C862D for ; Mon, 16 Mar 2026 10:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773658253; cv=none; b=doM+dQsxb+KWZb9nW1LAXOyuHouX06TJouZ/hCyot7B2D14vIxgs58iX0rqWoI0Ei361XB3nTokGEMNyLQ8kDuvNmYe6AmmtSGrETkVIh0rdaa5utbj8V7RojyL6R+A01viGHJGPTXz5ZvijsMBNNIauMgb8n3TSi7W58dv4YgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773658253; c=relaxed/simple; bh=WuphdEG5WMxLm6CNAhSgSsU6b0QIPWdhcGxytQxDhYg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MMRsU7pXdP0c92rW2VAKcJd2gUDpug331djI2So+T4ADuleWHBjK5051yi3GdpszHtHKcrFRa9gWZbSLI9bLvMBKxUb2yCBUxeuVDwOYuSVwNd4WUKGpgSjllZPdLX969HU8FGWkAf4t5bd2VBJE/3B5BVkLuzpNEaBT/jN7OwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M6KzD6Pw; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M6KzD6Pw" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b97ba4c2be2so104306366b.1 for ; Mon, 16 Mar 2026 03:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773658251; x=1774263051; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zX8fXT4dHsVZo0l5cubooJwv9HgtnAM6ONAUv7CG/fA=; b=M6KzD6PwcDBQIurPbir85r8pKHXKRKvTDPGiys1DP+DpQdsRT6jxbKM5lN5Uo1d0mC qEfWaP5s2QyE74wXIWEbmxVI+eC7y0SDlPNqhP8eZ+fXcvpFrOzJtEVao0MyjsTXMpzf Hhtehg10NKPFwzClLdoS8Vh+ifarA0vS8ijxz5Rs/VtiFmGKtQP0YWifeiX1MnajLoIt VE2qrswvd3SGB/bld90gl9GNBxN5CNs2G0FWkHmUWh/vHiqc18OXYzlVnQLVGLIgsrZf nLjscrbhwt248WYCrqfQ9TRtz/X6BcsVZYJTMBCxPZ0HcN++1n4vF1ZJrUbw17aHwMtt dwGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773658251; x=1774263051; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zX8fXT4dHsVZo0l5cubooJwv9HgtnAM6ONAUv7CG/fA=; b=RucIyiZPtT2Vj272o8U2PSZ5uBmSo7ozGeRrXwIy5u9LFSiyt5BB7D+0gXzFKRNp/g 4cF/p1Qwdf63YGB9d8e16LXYtvNV8azaSMNVQd6yp5P6kXbMEMloWaC4rfq4aMIejOV3 wySJOE3j7hfSx2Xfu24BZ53WJDBAEmufADfWqAuB1A7xFZU3dylHc3DlIMCKR64ot7eG N9Ffr4Y8d+paPyqXTCQqblW9g6LkD1IJ5wxEZuZ6Y6JGCHf289pPwPDEsoJ+2MKV+Lzz 8HfloTq81tDt7oU4eUQ1OEDr9u+zb9rm0HR1LJ6UjgrKsuVI9l+fqeU7PnIqBdW8IjPR Bybw== X-Forwarded-Encrypted: i=1; AJvYcCXGKW9RHKtZcrHqCdIVrlgUMoKu1XNcCm8n4KiFUL4FJzFOpLk3n83JTMdRHGoB0tGXnilcObH0YqXEFWM=@vger.kernel.org X-Gm-Message-State: AOJu0YwpXMGnO1YSbh9tenVDITPE4lbDjDvi7AGsLtblqdMrGI8SAbpk TEZkilpqd4CZ/9ubNHeHa5iWVsT3d5H0WKagSZeUTDmWTu7qG+Un9Teb X-Gm-Gg: ATEYQzxq9qskEBNNVTCsZbMyadu+TwoCokA6Uh7OQ5XY4ZUFmH9vNcIWUuB8qdUWyxq Ar7FADg9tc9dR//5wVyyZocaefXUyOXX0i2rkbJisRMOY6R5nzB2X7OxlRB87W33+zSRMiHJfnP FmCEYbVag/X4/VCV0uG+zEnttuhdI0uj3gogI82ftdPqolfMqkI49xow+UythfFiI9LsfK4RTdm xR1jyew4sy+3BMZWsQc5SUAXHlMP5yWepl/gchO52ctk7lZ/8tPpGs4pqBqtSdoxPK9LuKfLgEz INFtoZRzhC4GdTdNVfQi0/gnBcopvtv0xs7ZHfXM0RF+Ca/yEiuY2bF2jnV+PO65UfFBiHrX1h8 txlZKmVwkyKW8kSArcUnM2GilU0YeMG6jXXCE5LaBsU82fs99MhIqaqKKLZWqUwXgx1V2Wag6Q1 /OfRzGxMC25P650MjoCGLDuX5lqg== X-Received: by 2002:a17:906:3554:b0:b97:1009:7536 with SMTP id a640c23a62f3a-b9765052b4fmr564364966b.15.1773658250384; Mon, 16 Mar 2026 03:50:50 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cdb49a5sm539384566b.31.2026.03.16.03.50.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 03:50:50 -0700 (PDT) Message-ID: <6cc8f5ab-2671-4975-b24c-b17d4aab656d@gmail.com> Date: Mon, 16 Mar 2026 12:50:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/6] iio: light: vcnl4000: use variables for I2C client and device instances To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> <20260314-vcnl4000-regulators-v3-6-3c4a48d30676@gmail.com> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/16/26 12:39 PM, Andy Shevchenko wrote: > On Sat, Mar 14, 2026 at 06:06:35PM +0200, Erikas Bitovtas wrote: >> After moving data->client and client->dev into variables of their own, >> replace all instances of data->client and client->dev being used in >> vcnl4200_init and vcnl4000_probe by the said variables to reduce >> clutter. > > ... > >> - ret = i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF1, >> + ret = i2c_smbus_write_word_data(client, VCNL4200_PS_CONF1, >> regval); > > Now it's perfectly a single line. > > ret = i2c_smbus_write_word_data(client, VCNL4200_PS_CONF1, regval); > >> if (ret < 0) >> return ret; > > ... > >> regval = ret | VCNL4040_CONF3_PS_SAMPLE_16BITS; >> - ret = i2c_smbus_write_word_data(data->client, VCNL4200_PS_CONF3, >> + ret = i2c_smbus_write_word_data(client, VCNL4200_PS_CONF3, >> regval); > > Ditto. > >> if (ret < 0) >> return ret; > >> - if (device_property_read_u32(&client->dev, "proximity-near-level", >> + if (device_property_read_u32(dev, "proximity-near-level", >> &data->near_level)) >> data->near_level = 0; > > The 'if' is redundant, I think you can drop it at some point, probably to avoid > churn in the follow up > > - if (device_property_read_u32(&client->dev, "proximity-near-level", > - data->near_level = 0; > + device_property_read_u32(dev, "proximity-near-level", &data->near_level); > device_property_read_u32() throws an error if a property is missing. Would data->near_level be left without an assigned default value in that case?