From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB6D547CC81 for ; Thu, 30 Apr 2026 18:33:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777574038; cv=none; b=TTfwYTyeyonJmK7rIpsTTd5f6gQHlV41Qp81Z4WCoMf6nEbfiWvDwePNG4h7zvKh1DfFMlIii0eF9pQHYxTvp86A1O+FacjH7zRpoW27pX55zHuDnpvpDJIobccmIjQoe+CQC4EEkUIq+Pco0Eo80VGR1Vym4dIee8WBGUWqoEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777574038; c=relaxed/simple; bh=/jhj+TskCXODG9hKampnDGfknOGVmEGixC/boL6nPuc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hW8Dip1bPHFThC6u+/vEB2pOAHxyaHB5Nkv3HFPb61R/fVj62iusIZfiwefNLC76X69HdOfWYGmkUUdgRs5uk3AIOrBOtiC7DW8JNF6tFDVO1EYruD65Q9GmfxvJ/Bb4Ymjdn2RstOA1w2pKHES9LMjcae6L1RDu6Aih8/SJrYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IKYNxebG; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IKYNxebG" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43d77f6092eso821002f8f.2 for ; Thu, 30 Apr 2026 11:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777574035; x=1778178835; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NXLg+nrr3M9M+FT0+QCr6ZD6pc/R7QelMFoBuHbRWoU=; b=IKYNxebG99rJmgJdnK+STw62yP2P2cdaJBZG/cigckDb5MYyuKKqqi+dTFU2d9cFZy qhJhEBM2t2gYyYxeD5XqrpJttoMPpfwDkqQGaWge8r5FKsdQAdayH4cS/hC2kxIHEYq6 tGmHwVFWfDn2FZp49tR0EcsXlAigU9Sqe8yADo0AbxH22Zw75c684dLC6hfRE0EgxQSm HB1ngLvlfAIWqWDd9zNtUSfCDyoND4JMJTyGyjU3XxM4J+M97HrqUqLRf+QYygwaj1mC Ogr8gZjOmeYK1nNMGlcIaHaGVz3S2JshItziqGxqT+GC883q+Byb/VWR9AJNIaDrVgN5 mk/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777574035; x=1778178835; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NXLg+nrr3M9M+FT0+QCr6ZD6pc/R7QelMFoBuHbRWoU=; b=RC8wleyq/AYNB9bMHfp5I8HOlLv6UrlKe9rvl7FaP/uKU7YKxhJjn7QOcHhLTmlQAw gN3vagYrXGEy6jc5G3wEbgedayX1ytG5n5M70GAaKX/MnourlPsy2a3ChybBh6E5MP31 CKRkzjc1ml5yLtVwxbaBcoW//KxxVcCUMMCQ4hNO6cy6RnlkwD6gsFfrGFqna1vNTd8X AJaSj1LcguH/78tqDdMQRI79pQVuZZe7C5h9iLOpuR2PlOhEmpXw5K+m+ANTKqcPTjsh OfSjs0TLc2X96cXTFKZblNp7T5uG66RpQiVTmwnORZU02jm1sC7LyDAS8C5aHlUgmxsn VS3A== X-Forwarded-Encrypted: i=1; AFNElJ+t0l4jdpqoVvlwjJ+J3Nik09dXYwXIvdfZtLn47BN1EuckS3TJOqdW3hUWpM16eqRp8JFMClHBHhBXCUk=@vger.kernel.org X-Gm-Message-State: AOJu0YwB6cu8UBlY1i610i6wvZi7NEBmCCI+Pwm1gCnEMe5pzlF6LDsD X0SfbnaUtOT19/0DXfjeZ2uzyIZIhJeS5TthccC2L6hFO72MuvEtl3iO X-Gm-Gg: AeBDiet7T1cY+Vfedba0rRMEYBMLSDyqc0gMR7CDJwKda+EbHt16UTBe+wuF1UKxypZ q70SgdzBhf/NjSkIbbFF/rQtkcilqSrtsKFwG6mDTtqWILfe0z5amWdbwUlROAeF8tESqUyWY28 I76urO+Cw9qps+XobiqjDJrGPUWRqUZJ0NmRfBdc9cKo3sIMKoFgdex6XQqjRvuXPkgWDKSlg0L 3P+gHIxJwl/EI09AQB0tWqJJ28pm9aQWkXiNuC5vkovK2Ghn2V53C2Fc2BA/6Rpw0uIbmcqBF1+ dRSUbOk6t/RneHlh9wqMYu6TBKlMecral9wUldhQxBBiPwThan28fNYOubVjFEqsN5SsODA6khU zK3q+kdlSQoRh9QJNa2VEp3tDZGaTI9dd2n68CMU/bXuR/JRtAawkJaJbu48WAU2x0D0FPoOZV7 szVpCD453d2+aRPpRn8KviMCdp3jvEDLU7SP/wJvNs0Pq/VtPQE8F8o4f3SRuK7Knlf0d9g/zkA sDHNs4cQfPUk1Q8mO8GNSZR/+TC2fGHoKWijbQXibUfTxpN3KvP41mMnr405NBQVMEGdUGEC0dQ FA== X-Received: by 2002:a05:6000:1a8a:b0:43d:77a8:3baf with SMTP id ffacd0b85a97d-4493fa01beamr7079438f8f.32.1777574035154; Thu, 30 Apr 2026 11:33:55 -0700 (PDT) Received: from [10.109.92.8] (net-2-37-141-89.cust.vodafonedsl.it. [2.37.141.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-447b4216eecsm13579672f8f.9.2026.04.30.11.33.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 11:33:54 -0700 (PDT) Message-ID: <6cce2f4d-7400-4618-82ce-cbd5004c92a4@gmail.com> Date: Thu, 30 Apr 2026 19:33:39 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/10] file: add callback for creating long-term dmabuf maps To: =?UTF-8?Q?Christian_K=C3=B6nig?= , Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Cc: Nitesh Shetty , Kanchan Joshi , Anuj Gupta , Tushar Gohad , William Power , Phil Cayton , Jason Gunthorpe References: Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/30/26 07:03, Christian König wrote: > On 4/29/26 17:25, Pavel Begunkov wrote: >> Introduce a new file callback that allows creating long-term dma >> mapping. All necessary information together with a dmabuf will be passed >> in the second argument of type struct io_dmabuf_token, which will be >> defined in following patches. > > Well first of all the naming is probably not the best. Maybe rather call that dma-buf attachment or context or mappping. "Mapping" or "attachment" would be confusing as maps are created lazily together with struct io_dmabuf_map. I can name it create_dmabuf_ctx(), but I decided to use "token" not to collide with dmabuf terminology. e.g. I wouldn't be surprised to see some dmabuf ctx in the dmabuf implementation code. Maybe "*io_ctx" would be better. > Then the patch should probably define the full interface and not just add the callback here and then the structure in a follow up patch. I strongly prefer splitting patches so that they touch one tree at a time whenever possible. tbh, I don't see much of a problem it being not defined as it's just forwarded in first patches, but I can shuffle it around in the series so that definitions come first. -- Pavel Begunkov