From: Markus Elfring <Markus.Elfring@web.de>
To: Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
Ilia Mirkin <imirkin@alum.mit.edu>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-janitors@vger.kernel.org
Cc: Daniel Vetter <daniel@ffwll.ch>,
Danilo Krummrich <dakr@redhat.com>,
David Airlie <airlied@gmail.com>,
Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/nouveau/debugfs: Simplify character output in nouveau_debugfs_vbios_image()
Date: Wed, 24 Jul 2024 11:30:50 +0200 [thread overview]
Message-ID: <6ccf3891-fd72-47de-ab89-cdc7e9425c56@web.de> (raw)
In-Reply-To: <147bde68-2b66-4e0c-890d-30571a99eee1@wanadoo.fr>
>> Is there some reason this whole thing isn't just
>>
>> seq_write(m, drm->vbios.data, drm->vbios.length)
…
> I don't know if my answer is relevant or not here but:
> for () seq_putc(); ==> will fill 'm' with everything that fits in
I find such a discussion approach strange.
> and
> seq_write() ==> is all or nothing. So if 'm' is too small, then nothing will be appended.
The clarification can become more interesting for this system detail.
https://elixir.bootlin.com/linux/v6.10/source/fs/seq_file.c#L816
Was the sequence size (or the file capacity) appropriately configured?
Regards,
Markus
prev parent reply other threads:[~2024-07-24 9:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 11:48 [PATCH] drm/nouveau/debugfs: Simplify character output in nouveau_debugfs_vbios_image() Markus Elfring
2024-07-15 13:15 ` Ilia Mirkin
2024-07-23 16:23 ` [PATCH v2] drm/nouveau/debugfs: Optimise data " Markus Elfring
2024-07-23 16:57 ` [PATCH] drm/nouveau/debugfs: Simplify character " Christophe JAILLET
2024-07-23 17:03 ` Ilia Mirkin
2024-07-24 9:30 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ccf3891-fd72-47de-ab89-cdc7e9425c56@web.de \
--to=markus.elfring@web.de \
--cc=airlied@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=imirkin@alum.mit.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kherbst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox