[PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p

[PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p

[Mukesh Ojha]

Document the compatible for sa8775p SoC.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
 Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
index c6bd14ec5aa0..7d0b0b403150 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
@@ -21,6 +21,7 @@ properties:
           - qcom,msm8998-tcsr
           - qcom,qcm2290-tcsr
           - qcom,qcs404-tcsr
+          - qcom,sa8775p-tcsr
           - qcom,sc7180-tcsr
           - qcom,sc7280-tcsr
           - qcom,sc8280xp-tcsr
-- 
2.34.1

[PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space

[Mukesh Ojha]

Enable download mode for sa8775p which can help collect
ramdump for this SoC.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 23f1b2e5e624..a46d00b1ddda 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -221,6 +221,7 @@ eud_in: endpoint {
 	firmware {
 		scm {
 			compatible = "qcom,scm-sa8775p", "qcom,scm";
+			qcom,dload-mode = <&tcsr 0x13000>;
 			memory-region = <&tz_ffi_mem>;
 		};
 	};
@@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
 			#hwlock-cells = <1>;
 		};
 
+		tcsr: syscon@1fc0000 {
+			compatible = "qcom,sa8775p-tcsr", "syscon";
+			reg = <0x0 0x1fc0000 0x0 0x30000>;
+		};
+
 		gpucc: clock-controller@3d90000 {
 			compatible = "qcom,sa8775p-gpucc";
 			reg = <0x0 0x03d90000 0x0 0xa000>;
-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p

[Elliot Berman]

On Fri, Jul 05, 2024 at 09:02:51PM +0530, Mukesh Ojha wrote:
> Document the compatible for sa8775p SoC.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>

Reviewed-by: Elliot Berman <quic_eberman@quicinc.com>

> ---
>  Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> index c6bd14ec5aa0..7d0b0b403150 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> @@ -21,6 +21,7 @@ properties:
>            - qcom,msm8998-tcsr
>            - qcom,qcm2290-tcsr
>            - qcom,qcs404-tcsr
> +          - qcom,sa8775p-tcsr
>            - qcom,sc7180-tcsr
>            - qcom,sc7280-tcsr
>            - qcom,sc8280xp-tcsr
> -- 
> 2.34.1
> 
> 

Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space

[Elliot Berman]

On Fri, Jul 05, 2024 at 09:02:52PM +0530, Mukesh Ojha wrote:
> Enable download mode for sa8775p which can help collect
> ramdump for this SoC.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>

Reviewed-by: Elliot Berman <quic_eberman@quicinc.com>

> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 23f1b2e5e624..a46d00b1ddda 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -221,6 +221,7 @@ eud_in: endpoint {
>  	firmware {
>  		scm {
>  			compatible = "qcom,scm-sa8775p", "qcom,scm";
> +			qcom,dload-mode = <&tcsr 0x13000>;
>  			memory-region = <&tz_ffi_mem>;
>  		};
>  	};
> @@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
>  			#hwlock-cells = <1>;
>  		};
>  
> +		tcsr: syscon@1fc0000 {
> +			compatible = "qcom,sa8775p-tcsr", "syscon";
> +			reg = <0x0 0x1fc0000 0x0 0x30000>;
> +		};
> +
>  		gpucc: clock-controller@3d90000 {
>  			compatible = "qcom,sa8775p-gpucc";
>  			reg = <0x0 0x03d90000 0x0 0xa000>;
> -- 
> 2.34.1
> 
> 

Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p

[Krzysztof Kozlowski]

On 05/07/2024 17:32, Mukesh Ojha wrote:
> Document the compatible for sa8775p SoC.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>

Eh? SA8775p is going to be removed/changed... why adding this?

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space

[Krzysztof Kozlowski]

On 05/07/2024 17:32, Mukesh Ojha wrote:
> Enable download mode for sa8775p which can help collect
> ramdump for this SoC.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 23f1b2e5e624..a46d00b1ddda 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -221,6 +221,7 @@ eud_in: endpoint {
>  	firmware {
>  		scm {
>  			compatible = "qcom,scm-sa8775p", "qcom,scm";
> +			qcom,dload-mode = <&tcsr 0x13000>;
>  			memory-region = <&tz_ffi_mem>;
>  		};
>  	};
> @@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
>  			#hwlock-cells = <1>;
>  		};
>  
> +		tcsr: syscon@1fc0000 {
> +			compatible = "qcom,sa8775p-tcsr", "syscon";

The file is going away. This change is very confusing.

Please align first with your colleagues instead of sending conflicting
work without any explanation.

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space

[Mukesh Ojha]

On Sun, Jul 07, 2024 at 02:46:59PM +0200, Krzysztof Kozlowski wrote:
> On 05/07/2024 17:32, Mukesh Ojha wrote:
> > Enable download mode for sa8775p which can help collect
> > ramdump for this SoC.
> > 
> > Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> > ---
> >  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > index 23f1b2e5e624..a46d00b1ddda 100644
> > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > @@ -221,6 +221,7 @@ eud_in: endpoint {
> >  	firmware {
> >  		scm {
> >  			compatible = "qcom,scm-sa8775p", "qcom,scm";
> > +			qcom,dload-mode = <&tcsr 0x13000>;
> >  			memory-region = <&tz_ffi_mem>;
> >  		};
> >  	};
> > @@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
> >  			#hwlock-cells = <1>;
> >  		};
> >  
> > +		tcsr: syscon@1fc0000 {
> > +			compatible = "qcom,sa8775p-tcsr", "syscon";
> 
> The file is going away. This change is very confusing.
> 
> Please align first with your colleagues instead of sending conflicting
> work without any explanation.

Sure, let me check with Tengfei if this can be sent along with his patches.

-Mukesh

Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p

[Tengfei Fan]

On 7/7/2024 8:46 PM, Krzysztof Kozlowski wrote:
> On 05/07/2024 17:32, Mukesh Ojha wrote:
>> Document the compatible for sa8775p SoC.
>>
>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> 
> Eh? SA8775p is going to be removed/changed... why adding this?
> 
> Best regards,
> Krzysztof
> 

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Therefore, this patch is still needed, please continue to review this
patch.
Thank you for your input.

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space

[Tengfei Fan]

On 7/9/2024 12:08 AM, Mukesh Ojha wrote:
> On Sun, Jul 07, 2024 at 02:46:59PM +0200, Krzysztof Kozlowski wrote:
>> On 05/07/2024 17:32, Mukesh Ojha wrote:
>>> Enable download mode for sa8775p which can help collect
>>> ramdump for this SoC.
>>>
>>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> index 23f1b2e5e624..a46d00b1ddda 100644
>>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> @@ -221,6 +221,7 @@ eud_in: endpoint {
>>>   	firmware {
>>>   		scm {
>>>   			compatible = "qcom,scm-sa8775p", "qcom,scm";
>>> +			qcom,dload-mode = <&tcsr 0x13000>;
>>>   			memory-region = <&tz_ffi_mem>;
>>>   		};
>>>   	};
>>> @@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
>>>   			#hwlock-cells = <1>;
>>>   		};
>>>   
>>> +		tcsr: syscon@1fc0000 {
>>> +			compatible = "qcom,sa8775p-tcsr", "syscon";
>>
>> The file is going away. This change is very confusing.
>>
>> Please align first with your colleagues instead of sending conflicting
>> work without any explanation.
> 
> Sure, let me check with Tengfei if this can be sent along with his patches.
> 
> -Mukesh

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Therefore, this patch is still needed, please continue to review this
patch.
Thank you for your input.

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p

[Mukesh Ojha]

On Mon, Jul 29, 2024 at 06:48:51PM +0800, Tengfei Fan wrote:
> 
> 
> On 7/7/2024 8:46 PM, Krzysztof Kozlowski wrote:
> > On 05/07/2024 17:32, Mukesh Ojha wrote:
> > > Document the compatible for sa8775p SoC.
> > > 
> > > Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> > 
> > Eh? SA8775p is going to be removed/changed... why adding this?
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> After considering the feedback provided on the subject, We have decided
> to keep current SA8775p compatible and ABI compatibility in drivers.
> Therefore, this patch is still needed, please continue to review this
> patch.
> Thank you for your input.

Thanks Tengfei for the reply.

Can this series be considered now, it still applied fine on linux-next.

-Mukesh

> 
> -- 
> Thx and BRs,
> Tengfei Fan

Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p

[Krzysztof Kozlowski]

On 27/08/2024 18:04, Mukesh Ojha wrote:
>> After considering the feedback provided on the subject, We have decided
>> to keep current SA8775p compatible and ABI compatibility in drivers.
>> Therefore, this patch is still needed, please continue to review this
>> patch.
>> Thank you for your input.
> 
> Thanks Tengfei for the reply.
> 
> Can this series be considered now, it still applied fine on linux-next.

Please resend. No one has it in their mailbox anymore.

Best regards,
Krzysztof