* [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p
@ 2024-07-05 15:32 Mukesh Ojha
2024-07-05 15:32 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space Mukesh Ojha
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Mukesh Ojha @ 2024-07-05 15:32 UTC (permalink / raw)
To: lee, robh, krzk+dt, conor+dt, andersson, konrad.dybcio
Cc: linux-arm-msm, devicetree, linux-kernel, Mukesh Ojha
Document the compatible for sa8775p SoC.
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
index c6bd14ec5aa0..7d0b0b403150 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
@@ -21,6 +21,7 @@ properties:
- qcom,msm8998-tcsr
- qcom,qcm2290-tcsr
- qcom,qcs404-tcsr
+ - qcom,sa8775p-tcsr
- qcom,sc7180-tcsr
- qcom,sc7280-tcsr
- qcom,sc8280xp-tcsr
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space
2024-07-05 15:32 [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p Mukesh Ojha
@ 2024-07-05 15:32 ` Mukesh Ojha
2024-07-05 18:30 ` Elliot Berman
2024-07-07 12:46 ` Krzysztof Kozlowski
2024-07-05 18:21 ` [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p Elliot Berman
2024-07-07 12:46 ` Krzysztof Kozlowski
2 siblings, 2 replies; 11+ messages in thread
From: Mukesh Ojha @ 2024-07-05 15:32 UTC (permalink / raw)
To: lee, robh, krzk+dt, conor+dt, andersson, konrad.dybcio
Cc: linux-arm-msm, devicetree, linux-kernel, Mukesh Ojha
Enable download mode for sa8775p which can help collect
ramdump for this SoC.
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 23f1b2e5e624..a46d00b1ddda 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -221,6 +221,7 @@ eud_in: endpoint {
firmware {
scm {
compatible = "qcom,scm-sa8775p", "qcom,scm";
+ qcom,dload-mode = <&tcsr 0x13000>;
memory-region = <&tz_ffi_mem>;
};
};
@@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
#hwlock-cells = <1>;
};
+ tcsr: syscon@1fc0000 {
+ compatible = "qcom,sa8775p-tcsr", "syscon";
+ reg = <0x0 0x1fc0000 0x0 0x30000>;
+ };
+
gpucc: clock-controller@3d90000 {
compatible = "qcom,sa8775p-gpucc";
reg = <0x0 0x03d90000 0x0 0xa000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space
2024-07-05 15:32 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space Mukesh Ojha
@ 2024-07-05 18:30 ` Elliot Berman
2024-07-07 12:46 ` Krzysztof Kozlowski
1 sibling, 0 replies; 11+ messages in thread
From: Elliot Berman @ 2024-07-05 18:30 UTC (permalink / raw)
To: Mukesh Ojha
Cc: lee, robh, krzk+dt, conor+dt, andersson, konrad.dybcio,
linux-arm-msm, devicetree, linux-kernel
On Fri, Jul 05, 2024 at 09:02:52PM +0530, Mukesh Ojha wrote:
> Enable download mode for sa8775p which can help collect
> ramdump for this SoC.
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
Reviewed-by: Elliot Berman <quic_eberman@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 23f1b2e5e624..a46d00b1ddda 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -221,6 +221,7 @@ eud_in: endpoint {
> firmware {
> scm {
> compatible = "qcom,scm-sa8775p", "qcom,scm";
> + qcom,dload-mode = <&tcsr 0x13000>;
> memory-region = <&tz_ffi_mem>;
> };
> };
> @@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
> #hwlock-cells = <1>;
> };
>
> + tcsr: syscon@1fc0000 {
> + compatible = "qcom,sa8775p-tcsr", "syscon";
> + reg = <0x0 0x1fc0000 0x0 0x30000>;
> + };
> +
> gpucc: clock-controller@3d90000 {
> compatible = "qcom,sa8775p-gpucc";
> reg = <0x0 0x03d90000 0x0 0xa000>;
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space
2024-07-05 15:32 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space Mukesh Ojha
2024-07-05 18:30 ` Elliot Berman
@ 2024-07-07 12:46 ` Krzysztof Kozlowski
2024-07-08 16:08 ` Mukesh Ojha
1 sibling, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-07 12:46 UTC (permalink / raw)
To: Mukesh Ojha, lee, robh, krzk+dt, conor+dt, andersson,
konrad.dybcio
Cc: linux-arm-msm, devicetree, linux-kernel
On 05/07/2024 17:32, Mukesh Ojha wrote:
> Enable download mode for sa8775p which can help collect
> ramdump for this SoC.
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 23f1b2e5e624..a46d00b1ddda 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -221,6 +221,7 @@ eud_in: endpoint {
> firmware {
> scm {
> compatible = "qcom,scm-sa8775p", "qcom,scm";
> + qcom,dload-mode = <&tcsr 0x13000>;
> memory-region = <&tz_ffi_mem>;
> };
> };
> @@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
> #hwlock-cells = <1>;
> };
>
> + tcsr: syscon@1fc0000 {
> + compatible = "qcom,sa8775p-tcsr", "syscon";
The file is going away. This change is very confusing.
Please align first with your colleagues instead of sending conflicting
work without any explanation.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space
2024-07-07 12:46 ` Krzysztof Kozlowski
@ 2024-07-08 16:08 ` Mukesh Ojha
2024-07-29 10:50 ` Tengfei Fan
0 siblings, 1 reply; 11+ messages in thread
From: Mukesh Ojha @ 2024-07-08 16:08 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: lee, robh, krzk+dt, conor+dt, andersson, konrad.dybcio,
linux-arm-msm, devicetree, linux-kernel
On Sun, Jul 07, 2024 at 02:46:59PM +0200, Krzysztof Kozlowski wrote:
> On 05/07/2024 17:32, Mukesh Ojha wrote:
> > Enable download mode for sa8775p which can help collect
> > ramdump for this SoC.
> >
> > Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> > ---
> > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > index 23f1b2e5e624..a46d00b1ddda 100644
> > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> > @@ -221,6 +221,7 @@ eud_in: endpoint {
> > firmware {
> > scm {
> > compatible = "qcom,scm-sa8775p", "qcom,scm";
> > + qcom,dload-mode = <&tcsr 0x13000>;
> > memory-region = <&tz_ffi_mem>;
> > };
> > };
> > @@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
> > #hwlock-cells = <1>;
> > };
> >
> > + tcsr: syscon@1fc0000 {
> > + compatible = "qcom,sa8775p-tcsr", "syscon";
>
> The file is going away. This change is very confusing.
>
> Please align first with your colleagues instead of sending conflicting
> work without any explanation.
Sure, let me check with Tengfei if this can be sent along with his patches.
-Mukesh
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space
2024-07-08 16:08 ` Mukesh Ojha
@ 2024-07-29 10:50 ` Tengfei Fan
0 siblings, 0 replies; 11+ messages in thread
From: Tengfei Fan @ 2024-07-29 10:50 UTC (permalink / raw)
To: Mukesh Ojha, Krzysztof Kozlowski
Cc: lee, robh, krzk+dt, conor+dt, andersson, konrad.dybcio,
linux-arm-msm, devicetree, linux-kernel, kernel
On 7/9/2024 12:08 AM, Mukesh Ojha wrote:
> On Sun, Jul 07, 2024 at 02:46:59PM +0200, Krzysztof Kozlowski wrote:
>> On 05/07/2024 17:32, Mukesh Ojha wrote:
>>> Enable download mode for sa8775p which can help collect
>>> ramdump for this SoC.
>>>
>>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> index 23f1b2e5e624..a46d00b1ddda 100644
>>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>>> @@ -221,6 +221,7 @@ eud_in: endpoint {
>>> firmware {
>>> scm {
>>> compatible = "qcom,scm-sa8775p", "qcom,scm";
>>> + qcom,dload-mode = <&tcsr 0x13000>;
>>> memory-region = <&tz_ffi_mem>;
>>> };
>>> };
>>> @@ -2824,6 +2825,11 @@ tcsr_mutex: hwlock@1f40000 {
>>> #hwlock-cells = <1>;
>>> };
>>>
>>> + tcsr: syscon@1fc0000 {
>>> + compatible = "qcom,sa8775p-tcsr", "syscon";
>>
>> The file is going away. This change is very confusing.
>>
>> Please align first with your colleagues instead of sending conflicting
>> work without any explanation.
>
> Sure, let me check with Tengfei if this can be sent along with his patches.
>
> -Mukesh
After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Therefore, this patch is still needed, please continue to review this
patch.
Thank you for your input.
--
Thx and BRs,
Tengfei Fan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p
2024-07-05 15:32 [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p Mukesh Ojha
2024-07-05 15:32 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space Mukesh Ojha
@ 2024-07-05 18:21 ` Elliot Berman
2024-07-07 12:46 ` Krzysztof Kozlowski
2 siblings, 0 replies; 11+ messages in thread
From: Elliot Berman @ 2024-07-05 18:21 UTC (permalink / raw)
To: Mukesh Ojha
Cc: lee, robh, krzk+dt, conor+dt, andersson, konrad.dybcio,
linux-arm-msm, devicetree, linux-kernel
On Fri, Jul 05, 2024 at 09:02:51PM +0530, Mukesh Ojha wrote:
> Document the compatible for sa8775p SoC.
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
Reviewed-by: Elliot Berman <quic_eberman@quicinc.com>
> ---
> Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> index c6bd14ec5aa0..7d0b0b403150 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> @@ -21,6 +21,7 @@ properties:
> - qcom,msm8998-tcsr
> - qcom,qcm2290-tcsr
> - qcom,qcs404-tcsr
> + - qcom,sa8775p-tcsr
> - qcom,sc7180-tcsr
> - qcom,sc7280-tcsr
> - qcom,sc8280xp-tcsr
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p
2024-07-05 15:32 [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p Mukesh Ojha
2024-07-05 15:32 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space Mukesh Ojha
2024-07-05 18:21 ` [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p Elliot Berman
@ 2024-07-07 12:46 ` Krzysztof Kozlowski
2024-07-29 10:48 ` Tengfei Fan
2 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2024-07-07 12:46 UTC (permalink / raw)
To: Mukesh Ojha, lee, robh, krzk+dt, conor+dt, andersson,
konrad.dybcio
Cc: linux-arm-msm, devicetree, linux-kernel
On 05/07/2024 17:32, Mukesh Ojha wrote:
> Document the compatible for sa8775p SoC.
>
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
Eh? SA8775p is going to be removed/changed... why adding this?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p
2024-07-07 12:46 ` Krzysztof Kozlowski
@ 2024-07-29 10:48 ` Tengfei Fan
2024-08-27 16:04 ` Mukesh Ojha
0 siblings, 1 reply; 11+ messages in thread
From: Tengfei Fan @ 2024-07-29 10:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, Mukesh Ojha, lee, robh, krzk+dt, conor+dt,
andersson, konrad.dybcio
Cc: linux-arm-msm, devicetree, linux-kernel, Tingwei, Aiqun(Maria) Yu
On 7/7/2024 8:46 PM, Krzysztof Kozlowski wrote:
> On 05/07/2024 17:32, Mukesh Ojha wrote:
>> Document the compatible for sa8775p SoC.
>>
>> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
>
> Eh? SA8775p is going to be removed/changed... why adding this?
>
> Best regards,
> Krzysztof
>
After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Therefore, this patch is still needed, please continue to review this
patch.
Thank you for your input.
--
Thx and BRs,
Tengfei Fan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p
2024-07-29 10:48 ` Tengfei Fan
@ 2024-08-27 16:04 ` Mukesh Ojha
2024-08-27 17:31 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Mukesh Ojha @ 2024-08-27 16:04 UTC (permalink / raw)
To: Tengfei Fan
Cc: Krzysztof Kozlowski, lee, robh, krzk+dt, conor+dt, andersson,
konrad.dybcio, linux-arm-msm, devicetree, linux-kernel, Tingwei,
Aiqun(Maria) Yu
On Mon, Jul 29, 2024 at 06:48:51PM +0800, Tengfei Fan wrote:
>
>
> On 7/7/2024 8:46 PM, Krzysztof Kozlowski wrote:
> > On 05/07/2024 17:32, Mukesh Ojha wrote:
> > > Document the compatible for sa8775p SoC.
> > >
> > > Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> >
> > Eh? SA8775p is going to be removed/changed... why adding this?
> >
> > Best regards,
> > Krzysztof
> >
>
> After considering the feedback provided on the subject, We have decided
> to keep current SA8775p compatible and ABI compatibility in drivers.
> Therefore, this patch is still needed, please continue to review this
> patch.
> Thank you for your input.
Thanks Tengfei for the reply.
Can this series be considered now, it still applied fine on linux-next.
-Mukesh
>
> --
> Thx and BRs,
> Tengfei Fan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p
2024-08-27 16:04 ` Mukesh Ojha
@ 2024-08-27 17:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-27 17:31 UTC (permalink / raw)
To: Mukesh Ojha, Tengfei Fan
Cc: lee, robh, krzk+dt, conor+dt, andersson, konrad.dybcio,
linux-arm-msm, devicetree, linux-kernel, Tingwei, Aiqun(Maria) Yu
On 27/08/2024 18:04, Mukesh Ojha wrote:
>> After considering the feedback provided on the subject, We have decided
>> to keep current SA8775p compatible and ABI compatibility in drivers.
>> Therefore, this patch is still needed, please continue to review this
>> patch.
>> Thank you for your input.
>
> Thanks Tengfei for the reply.
>
> Can this series be considered now, it still applied fine on linux-next.
Please resend. No one has it in their mailbox anymore.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-08-27 17:32 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-05 15:32 [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p Mukesh Ojha
2024-07-05 15:32 ` [PATCH 2/2] arm64: dts: qcom: sa8775p: Add TCSR halt register space Mukesh Ojha
2024-07-05 18:30 ` Elliot Berman
2024-07-07 12:46 ` Krzysztof Kozlowski
2024-07-08 16:08 ` Mukesh Ojha
2024-07-29 10:50 ` Tengfei Fan
2024-07-05 18:21 ` [PATCH 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sa8775p Elliot Berman
2024-07-07 12:46 ` Krzysztof Kozlowski
2024-07-29 10:48 ` Tengfei Fan
2024-08-27 16:04 ` Mukesh Ojha
2024-08-27 17:31 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox