From: William Qiu <william.qiu@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<devicetree@vger.kernel.org>, <linux-pwm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Thierry Reding <thierry.reding@gmail.com>,
Hal Feng <hal.feng@starfivetech.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: PWM: Add StarFive PWM module
Date: Fri, 10 Mar 2023 16:28:26 +0800 [thread overview]
Message-ID: <6cde3607-cc9d-ec31-2ddd-921065a3e52d@starfivetech.com> (raw)
In-Reply-To: <f02e072c-a963-669c-95b7-e093a0073bde@linaro.org>
On 2023/3/10 16:26, Krzysztof Kozlowski wrote:
> On 10/03/2023 08:45, William Qiu wrote:
>> Add documentation to describe StarFive Pulse Width Modulation
>> controller driver.
>>
>> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
>
> (...)
>
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + pwm@120d0000 {
>> + compatible = "starfive,jh7110-pwm";
>> + reg = <0x120d0000 0x10000>;
>> + clocks = <&syscrg 121>;
>> + resets = <&syscrg 108>;
>> + #pwm-cells=<3>;
>
> Missing spaces around =
>
> With above:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>
> Best regards,
> Krzysztof
>
Will update.
Thanks for taking time to review this patch series.
Best regards
William
next prev parent reply other threads:[~2023-03-10 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 7:45 [PATCH v2 0/2] StarFive's Pulse Width Modulation driver support William Qiu
2023-03-10 7:45 ` [PATCH v2 1/2] dt-bindings: PWM: Add StarFive PWM module William Qiu
2023-03-10 8:26 ` Krzysztof Kozlowski
2023-03-10 8:28 ` William Qiu [this message]
2023-03-10 7:45 ` [PATCH v2 2/2] pwm: starfive: Add PWM driver support William Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cde3607-cc9d-ec31-2ddd-921065a3e52d@starfivetech.com \
--to=william.qiu@starfivetech.com \
--cc=devicetree@vger.kernel.org \
--cc=hal.feng@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox