From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55C211865; Mon, 19 Feb 2024 02:35:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708310119; cv=none; b=pEi+77dSa1001qyl7mr5zkTwUSasUrZIz8QHTq6951vwt1EuhFSX5zkquR7ahKBzRvjKTnJgbga/UIhHlXfuVEiHivrnvouHxFToycztkuyC4AG0NqZj54nU2kBAeklnUNuXcxGZRO6BbOZO8Z4qkK9VG2AVFyFUTXTbUZiFJxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708310119; c=relaxed/simple; bh=7vOsgnul1GxbRF0500oTwAAKvmXKzp4WUWTaSsUsX/s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NM1M06IE/gqOoIDtgkaTo9HmAymsDxgVrEE4AVEPFNZPPrHFCZt3vKWR3WbrxTpFXu+tjHcvexGk4v2Vkf1KMYRy1RwA18OQWwCIxCh1ZXuyzy/7ofIx6iiLC9ZzPOTp/2wh9TFFXFg9X5pZpm11GtoxrN70EXAkEPO22YPDp3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ick1dCly; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ick1dCly" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2962C433F1; Mon, 19 Feb 2024 02:35:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708310118; bh=7vOsgnul1GxbRF0500oTwAAKvmXKzp4WUWTaSsUsX/s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ick1dClyqIco0cQcwmp2zXklGRJkUPdQ97kzOUHpc922pxfPbZkj5TQ9x8Sbetr1L dDAPm/j05sE89tZm59u5YAhad90hTb1aUnXwbQbzDz4+VhhIPwSFmWXhFVsSVc+0ul HPVAv1/kicGlE8bd1ydxSYHQn3sifhXsVHrn4UkJQj0KTBLnc3s8LKtl9hASIa9kv0 T6mMtz34xwwp4gnQCP47pW5sieNrMbzMiPzJINsJl2aXgl0uxCG1UE8O3ggHeCP0RH 3GEG4NG9/22PQ/gyUMxhGJOZRqsw72Jp2s2KaLA441uDoMhlq0g1wFlipahErJ+/EI OXo+v7/LByz6Q== Message-ID: <6d14ea70-ac1c-46f2-af1d-ba34ea0165aa@kernel.org> Date: Mon, 19 Feb 2024 10:35:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [regression 6.1.y] f2fs: invalid zstd compress level: 6 To: Salvatore Bonaccorso , Dhya , 1063422@bugs.debian.org, Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org, regressions@lists.linux.dev References: <170736382774.1975.1861975122613668970.reportbug@tsuga.picorealm.net> Content-Language: en-US From: Chao Yu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/2/9 4:19, Salvatore Bonaccorso wrote: > Hi Jaegeuk Kim, Chao Yu, > > In Debian the following regression was reported after a Dhya updated > to 6.1.76: > > On Wed, Feb 07, 2024 at 10:43:47PM -0500, Dhya wrote: >> Package: src:linux >> Version: 6.1.76-1 >> Severity: critical >> Justification: breaks the whole system >> >> Dear Maintainer, >> >> After upgrade to linux-image-6.1.0-18-amd64 6.1.76-1 F2FS filesystem >> fails to mount rw. Message in the boot journal: >> >> kernel: F2FS-fs (nvme0n1p6): invalid zstd compress level: 6 >> >> There was recently an f2fs patch to the 6.1 kernel tree which might be >> related: https://www.spinics.net/lists/stable-commits/msg329957.html >> >> Was able to recover the system by doing: >> >> sudo mount -o remount,rw,relatime,lazytime,background_gc=on,discard,no_heap,user_xattr,inline_xattr,acl,inline_data,inline_dentry,extent_cache,mode=adaptive,active_logs=6,alloc_mode=default,checkpoint_merge,fsync_mode=posix,compress_algorithm=lz4,compress_log_size=2,compress_mode=fs,atgc,discard_unit=block,memory=normal /dev/nvme0n1p6 / >> >> under the running bad 6.1.0-18-amd64 kernel, then editing >> /etc/default/grub: >> >> GRUB_DEFAULT="Advanced options for Debian GNU/Linux>Debian GNU/Linux, with Linux 6.1.0-17-amd64" >> >> and running 'update-grub' and rebooting to boot the 6.1.0-17-amd64 >> kernel. > > The issue is easily reproducible by: > > # dd if=/dev/zero of=test.img count=100 bs=1M > # mkfs.f2fs -f -O compression,extra_attr ./test.img > # mount -t f2fs -o compress_algorithm=zstd:6,compress_chksum,atgc,gc_merge,lazytime ./test.img /mnt > > resulting in > > [ 60.789982] F2FS-fs (loop0): invalid zstd compress level: 6 Hi Salvatore, Can you please try below fixes: [PATCH 6.1] f2fs: add helper to check compression level https://lore.kernel.org/linux-f2fs-devel/20240212160530.1017205-1-chao@kernel.org [PATCH] f2fs: compress: fix to check zstd compress level correctly in mount option https://lore.kernel.org/linux-f2fs-devel/20240212160818.1020903-1-chao@kernel.org Thanks, > > A bugzilla report has been submitted in > https://bugzilla.kernel.org/show_bug.cgi?id=218471 > > #regzbot introduced: v6.1.69..v6.1.76 > #regzbot link: https://bugs.debian.org/1063422 > #regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=218471 > > Regards, > Salvatore