From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75449A31; Sun, 6 Oct 2024 08:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728205039; cv=none; b=N0qO6EbrDN7me10vOVlowqIBh/qC/5G6r1k/VTDSnmOqBHhYbQYJaTJqUkEaN3jFUVs2PGrqmphjmMMCENygNOLuWUS5jMWpj0x2lGXAQRgfP0Qc6ZwHz57YlSRMI8ZFr9vNsVcs4yv48+guUhKLgexQ8cb2QlMHgMYmhmRbbWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728205039; c=relaxed/simple; bh=Wpido9Kf/hvaKPT3kLqwH4CTFoVCPwgVYoycmspxKVg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QR4WWcb4aOGF0RwabfNJ0Q4NJBaGP4UdWvgOOj0G189/OrWc0WL4rpXKmgocvepm8QglStw9FrsrEX3TPpL6CLu8jBGqtzc85vrfdSqCTX+Clr5yvZ8f4/S8hQcR8CogwBIZqiBbezcyprDvNrzCKd/gdFG+u3jeHVrYNDgzksU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=hw9N2iS+; arc=none smtp.client-ip=212.227.17.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="hw9N2iS+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1728205013; x=1728809813; i=markus.elfring@web.de; bh=BIrwPlkTYIFaxGZHJcTFOF4qlwUrg6aOe4aE4Kc20jM=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=hw9N2iS+tT6yz2seCRkfYGlTsBR9U5M2c3ugP957wVDIf7eXavfmHhqEHVGRFiDx NGZuD08/HkCN+kTISHP/7w7it4T+A3yGuyF6PIRA0wwzYM534EbwvCl90vH6/fjSM Bhls+9PCjRWw6MAG9/Apb/sEpw83HwmfyRdsbd5kCevm4ZEdmLP0SX2HeAqeHdqkW oowvblL0TMjz3SBiB2BDmJtyLzbESTHAQSjJUmSvcrKYoGVYtba7kJMzHMpRqYW4A iJ3+kWc51XJys9sDHoHgtfvprA1oiO5pkUKzN0zAZPV+j85U5hSW5c9B0w8g/sCU4 BlOEFU7LwhB9Wvj8rw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.87.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MSqXM-1tQV350QOs-00Ro1A; Sun, 06 Oct 2024 10:56:53 +0200 Message-ID: <6d17006d-ee97-4c7c-a355-245f32fe1fc3@web.de> Date: Sun, 6 Oct 2024 10:56:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: qcom: Fix NULL Dereference in asoc_qcom_lpass_cpu_platform_probe() To: Greg Kroah-Hartman , Zichen Xie , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Jaroslav Kysela , Liam Girdwood , Mark Brown , Rohit kumar , Srinivas Kandagatla , Takashi Iwai , stable@vger.kernel.org, LKML , Chenyuan Yang , Zijie Zhao References: <20241003152739.9650-1-zichenxie0106@gmail.com> <2024100620-decency-discuss-df6e@gregkh> Content-Language: en-GB From: Markus Elfring In-Reply-To: <2024100620-decency-discuss-df6e@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:jTPeINaQftL8b2MzXONGYdc/E9Af1aAvOORf/CE0M7cm1Obw5qd LU2OVArBY5A4mwcydPSsvUujrrMYmQ03tvpohyPLy2hkEwsEr3pIRUzhMam251qPZ1XLpOl BvoQ08Xs33MkDj/IUZFJgbupoeZj1JIPrcuLdz785TXdRiswkCZW7cfiCqTNrWdNCj5JKdJ TQ7zKPCYVQu6egYxi9QSw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:wiu11a04sOI=;vU2wESOvjSd2DSRm4DJW2MSEhfc fEVMQ7wruXhyaYrVabKlQhIfv0Npp/t+RBJEn/swIad3aATLganRZshY6Vs0zV8Z+sqZQj8S1 OubjqPqqkkjyWywNZrDi/FOBxWYsMYTi0s+Na2t5QHeIrgwTOQg0Ndrtml2sxqqhzkt0ox9I7 LeoGz8YDPwy7Yv7I0pt0hBz2M5YH478Z+wR4LteTrYmjW//AH84+9ladv8djjdKseTz162ebV O+s55JAIM1eHQoXyT0cldVVTlEwFHG4yc6wej2OPDeeRLsnjCPvURhMxmKNgNqJpDYjD8PlHX T51milFsMU02UC7G407wsTpx8xakS1EzBh9PnlrTtjIqto4ccDEKzubsv7R3OkU7fjHojynBc hcSL3ly7bM2i1Kmg8RRBpI/oUJNg4gKb3ZM06mdy0ANOZS1tYZ0XJTj7FC0SLibI4nqZmTBHz BT7Eo8ZT0W0sKma8yLEP1OXnXfaS9XyOynPf+P1tfUTK2wdBi6/SdgfDXaLSal34/VJEBGOul cHMfVLjQxRNnMNY20ggTs3qQWj16haf1KVyjwSR17+wonMGbfkFacWLd0nF+Et2PoehLh/AQ6 OChJUcZ2W8OXFmAtEtP8iJonjgur70AqSJViX8WiFB5wNBvgXaiGleYP952jXKVY8oLxVJ9mn mbjPkQKuNwVwFMBu3QTBZ15SM9oC2GzYgg3snzj/08fD2tAPiqpRDwKY5pO3O/lDZuviUwR8u 1hr/HM+PYN4QiEiBkqJmrJtg33zQ3yywUsCBRxxRKr1AKSq9CMX9a0YmQemp3i7wnZo5+j6eh fLX5p6bi1vCtPgulWCWz/aNA== >>> A devm_kzalloc() in asoc_qcom_lpass_cpu_platform_probe() could >> >> call? >> >> >>> possibly return NULL pointer. NULL Pointer Dereference may be >>> triggerred without addtional check. >> =E2=80=A6 >> >> * How do you think about to use the term =E2=80=9Cnull pointer derefere= nce=E2=80=9D >> for the final commit message (including the summary phrase)? >> >> * Would you like to avoid any typos here? >> >> >> =E2=80=A6 >>> --- >>> sound/soc/qcom/lpass-cpu.c | 2 ++ >> >> Did you overlook to add a version description behind the marker line? >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree= /Documentation/process/submitting-patches.rst?h=3Dv6.12-rc1#n723 =E2=80=A6 > This is the semi-friendly patch-bot of Greg Kroah-Hartman. > > Markus, you seem to have sent a nonsensical or otherwise pointless > review comment to a patch submission on a Linux kernel developer mailing > list. I strongly suggest that you not do this anymore. Please do not > bother developers who are actively working to produce patches and > features with comments that, in the end, are a waste of time. > > Patch submitter, please ignore Markus's suggestion; you do not need to > follow it at all. The person/bot/AI that sent it is being ignored by > almost all Linux kernel maintainers for having a persistent pattern of > behavior of producing distracting and pointless commentary, and > inability to adapt to feedback. Please feel free to also ignore emails > from them. * Do you care for any spell checking? * Do you find any related advice (from other automated responses) helpful? Regards, Markus