The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Michael Bommarito <michael.bommarito@gmail.com>
Cc: Mat Martineau <martineau@kernel.org>,
	Geliang Tang <geliang@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Gang Yan <gang.yan@linux.dev>,
	mptcp@lists.linux.dev, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] mptcp: only set DATA_FIN when a mapping is present
Date: Fri, 10 Jul 2026 19:30:55 +0200	[thread overview]
Message-ID: <6d1d35c5-64bc-466e-89bc-69bfacf39c57@kernel.org> (raw)
In-Reply-To: <CAJJ9bXxYfCPgh6ZsMCXf6YrpEPPzKmOcDwD0L1cNcWAefBFTLg@mail.gmail.com>

On 10/07/2026 19:17, Michael Bommarito wrote:
> On Fri, Jul 10, 2026 at 12:19 PM Matthieu Baerts <matttbe@kernel.org> wrote:
>>
>> I tried to reproduce it on my side using packetdrill-mptcp [1], but I
>> was not able to test with KMSAN: my kernel boot, but is stuck when KMSAN
>> is enabled... By chance, if you can try this reproducer on your side,
>> with and without your patched kernel, that would be great :)
>>
>> [1] https://github.com/multipath-tcp/packetdrill/pull/203
> 
> Can you try with more RAM and make sure that you have these set too?
> 
> CONFIG_CRYPTO_USER_API=y
> CONFIG_CRYPTO_USER_API_HASH=y

Thank you for the suggestion. Yes, I did use more RAM (just tried with
8G just to be sure), and with the CRYPTO_USER_API (needed for
packetdrill), but the VM stalls at boot time:

  Starting KernelMemorySanitizer
  ATTENTION: KMSAN is a debugging tool! Do not use it on production
machines!

I didn't investigate more, but I'm using KMSAN on another similar
machine with syzkaller without issues.
> I was able to get your PR #203 test to trigger after using -m 8G +
> AF_ALG under vng

Nice, thank you for having checked that! I guess I can merge this PR then.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


      reply	other threads:[~2026-07-10 17:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 19:19 [PATCH net v3] mptcp: only set DATA_FIN when a mapping is present Michael Bommarito
2026-07-10 16:19 ` Matthieu Baerts
2026-07-10 17:17   ` Michael Bommarito
2026-07-10 17:30     ` Matthieu Baerts [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d1d35c5-64bc-466e-89bc-69bfacf39c57@kernel.org \
    --to=matttbe@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gang.yan@linux.dev \
    --cc=geliang@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martineau@kernel.org \
    --cc=michael.bommarito@gmail.com \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox