Re: [PATCH -next] fuse: return the more nuanced writeback error on close()

Al Viro
2022-05-18T14:52:05Z

On Wed, May 18, 2022 at 10:57:29PM +0800, ChenXiaoSong wrote:

> + /* return more nuanced writeback errors */
> if (err)
> - return err;
> + return filemap_check_wb_err(file->f_mapping, 0);
>
> err = 0;

As an aside, what the hell is that err = 0 about? Before or after
that patch, that is - "let's make err zero, in case it had somehow
magically changed ceased to be so since if (err) bugger_off just above"?