From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43B5D3D3D05 for ; Fri, 24 Apr 2026 15:58:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777046284; cv=none; b=Cl97kJO4jnFkpcaYRF0QKOCMqYgK9dKPJKvU5P81uELagu7W8MM3k1x2UxFgnngE+FOFEtImT40t2ZoonTTpzeQWLIiCABXP5/VBq78/9C7fYC7fe6JYp9SYiByiA8aumbgwVZSGMXCJ1lRRx9Mlr6SKRmKwctBWGGaftmrhr9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777046284; c=relaxed/simple; bh=+1ftvCaFRzsm43wGy5+bwp8fcU4UHrSJINM9bARr8GM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b0SxMkifo5LGJyxnBBRHivUmISUum4n26MhfWE+TFdFbG9UwMws19JGqx4chfkqdQNE3HOMe7dQNJRmKuSYIcVI051tRTlbkw1BvhaC5pTfnWi82b/sAspQ8RQagK2FF45B38PpfdqH4qvHciivQird4PwKZvnBhE7LhcFje0Os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sTYRviJr; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sTYRviJr" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-35da1af3e10so7548870a91.3 for ; Fri, 24 Apr 2026 08:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777046282; x=1777651082; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6d9O+EApwiYusXJ1DgeMKm21JvxKbBPp2Rt3rYT/6rc=; b=sTYRviJrZzO26EMVgFdwPya/sQ5ESVKvDUPT/XLbVk6n/kI8Y3iZtd+tnNjFQK4qAO ZmAG68R8SOd8J4LIq/Uhtz52P1w9zJEi6qOig7Q/LVRLNQxFXNhkdu3Ck9PXQzVssQi4 +J752KmcowEB6pDO0mZlev8aps1L5MWLLsnydQUEEq0CLPc0Z4h1uBMD8lrmsdyAR+Md sGEM7pbYgehiNtrXheqpUmVJipHUsde27NMUutdl44iUx3+w3g4rqLDCp5rwqjHAeodF lVfM637cUy3MdApjLNvHJptbfgEEPHkJ4mcjPegloCzp3OSFyiQksCC5fh4EXsCs4nuo WgWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777046282; x=1777651082; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6d9O+EApwiYusXJ1DgeMKm21JvxKbBPp2Rt3rYT/6rc=; b=He/pm/ySSmSsxaXWQsWK52X7zGUoUC7EwJOyDbwxYNtxeQbzHqMNl7XBcor0AQFIIo lcWaB+VevhD6Duvi3Su48uO2VVRzzuvUiAOhFEMWF87j2RDzmFAOtc3ZpaBxaTbryfi8 a3bPiPJ5Ty4D5JjQ3WH8i5vMwXK4YW4F14m2Ks8CpdOBGeaE5W5G44k0xhB1SnXxwnFF bROpXp/1UOetY048jFK1zYfQxW34wQV2oKgaVVvIf34jYe6R8GnAJtafWyb6OGdwtAIW y/v8QBS9VxvqmAXnSPYJFvd21RKQ8AdD2Eil2/2g9J33r2Fw662f0JIFwt3NkwTfFn8D aJTA== X-Forwarded-Encrypted: i=1; AFNElJ8dUjKl3mx7rPpfpvicq9x9apGmQMFwT6Jc+6bB/9DkkpP28/B86vC3vR3HDC7HoklI/U8rer5nn/JT5nI=@vger.kernel.org X-Gm-Message-State: AOJu0YxneVUhPDcnrt0b7v70hObfuP73NHk6J7TzSsyFl8Iio+ws4Awj bApYx6Em/EmASuEsZDOJ/t/lbyUvShqJ9bPoAXQ1T2d4WnZvbugMsBoz X-Gm-Gg: AeBDietC6ywSI+JWKBCg1WNxDcL45OQA+OU0Ta8bubwWf39YtpFbwrOnJSRK0qViylw VEawI2nO3tCaDnmImXQnFy4rkwCsQ/2qx89H1HmTmurbJKQRcUE8yzo2yFSX5mmhwp1hmR2+dzu TbaNq22AbVKshWS2g9+Rvl7IjC125GQLz4SHajbMiV8Y96eSYFBAjt/E+nQK7X6aQ+E72i660zx A6W/tc0bWLBt9V+movQw4fXAyfqBQ0GewkdIDy/a8ni7ny1rUm340cMMM/zr8EgIDYYqFAnBuqn 7LUQkDYLY84ppSDgnr9A6tNG6mMvKrdzxhy14sm/iQcJqtpj4zoYUTC3hQEWnhn3gxEI0Fd3O9/ Ci4En1+CBKyNtr0ySlEgAONg/haR9xDhqBdKuZ8hm/RLRBI7zpLqdzLWM5btwVO7rGdRH1QPQMN QYM1wwXq6GHdKURqL7ufeU6F9gz5Ll5LuO8sOOAf4g8PU3IsaE6rsqj00yTX7kuFoUzjVNF9qDm TiFxM+Q7GsCxR4zmjeKTg== X-Received: by 2002:a17:90b:4fcc:b0:35f:b293:7ac6 with SMTP id 98e67ed59e1d1-361403bd8camr35057922a91.6.1777046281644; Fri, 24 Apr 2026 08:58:01 -0700 (PDT) Received: from [192.168.0.5] (124-218-201-66.cm.dynamic.apol.com.tw. [124.218.201.66]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36141973c57sm23333233a91.14.2026.04.24.08.57.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 08:58:01 -0700 (PDT) Message-ID: <6da66e31-3843-478c-9dd3-b2a9205026fd@gmail.com> Date: Fri, 24 Apr 2026 23:57:57 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] net: phy: air_en8811h: add AN8811HB MCU assert/deassert support To: Andrew Lunn , Paolo Abeni Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn@mork.no, ericwouds@gmail.com, frank-w@public-files.de, daniel@makrotopia.org, lucien.jheng@airoha.com, albert-al.lee@airoha.com References: <20260420134506.35164-1-lucienzx159@gmail.com> <2f6fd850-e187-4e63-9a32-6b4b72c09905@redhat.com> <18d653c9-e8fe-48ed-9524-869f79a63121@lunn.ch> Content-Language: en-US From: "Lucien.Jheng" In-Reply-To: <18d653c9-e8fe-48ed-9524-869f79a63121@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Andrew Lunn 於 2026/4/23 下午 07:58 寫道: >>> @@ -1175,10 +1281,22 @@ static int an8811hb_probe(struct phy_device *phydev) >>> return -ENOMEM; >>> phydev->priv = priv; >>> >>> + mdiodev = mdio_device_create(phydev->mdio.bus, >>> + phydev->mdio.addr + EN8811H_PBUS_ADDR_OFFS); >> Sashiko says: >> >> Can this create an out-of-bounds array access if the base PHY address is >> high? >> The mdio_map array in struct mii_bus has a fixed size of PHY_MAX_ADDR (32). >> If phydev->mdio.addr is 24 or higher, adding EN8811H_PBUS_ADDR_OFFS (8) >> will result in an address of 32 or more. >> Neither mdio_device_create() nor mdio_device_register() validate that >> the address is within PHY_MAX_ADDR. When mdiobus_register_device() >> executes mdiodev->bus->mdio_map[mdiodev->addr] = mdiodev, could this >> write past the end of the array and corrupt adjacent memory? > This has been discussed once, but Sashiko has a shorter memory than a > goldfish. It is guaranteed by hardware design that + 8 will work. Got it Thanks > > Andrew