From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81BF23EBF0D for ; Mon, 26 Jan 2026 18:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769453568; cv=none; b=d6qCIRlcWM+JImIMy0DlamDCRQkeG9dKwySMFpuB/y6aNlNBUNPe429vGGOZwD1t5YBjh8DWH2paaSND++WQwMwrcCARpG+hb9rNloxriSUagjgUrcF+WLkv7O4q/UpCS8qn71XSHs/wp7hJOkAd0viRN1VxXxCC47GXKGqH9SY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769453568; c=relaxed/simple; bh=h8IB/J037qzfODb/AKC4Cviqt5GuYeUYBXKiOfbv9X8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XQwETEl03IOdRhsaxjQil/ZhpNvWht9cWtRJNla71k4XNmky3IEVVef2GVBqVjjgdrzwnsyVfis77XHFh4YqwNdQAOVcQjFG/JifXxSOKnX3zNoeEc8Fws48fuuofVgetaRHFUbQrWvJxpgIfAee68d+EwOeQBritBTV9jaTn2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=iKRb7ZDX; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="iKRb7ZDX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1769453565; bh=h8IB/J037qzfODb/AKC4Cviqt5GuYeUYBXKiOfbv9X8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iKRb7ZDXk27k1R3CpuO6ivYT4IXiFvBbnWpQX+Ad12rE11s4qMSHr1Vb6PEIQA3hK SZO8+hUnkff/ndlJuoXtxPlZQvHW/3MIoo3891YyT70Py833ryXyh1358QOc8S03Te occ+5JoSA/YQFwAJEvR3G/Cq/wBRQLRzKVkAuCLVrba6qmXSWlX+bYr2fS2T0OBE3e v7Kn+usA8ImRxqXhe729EE5WIKH27QepcHrXH6SnViIv6HInNoOVt04WICvw3E2BGy joPCGnCh8m0hw9+moQ4lVIr4pPzcQYJCKyb5IAhIZ9e3hQSYYr+3cRf+sFgFNhM79H B6ZxqyoQfOnqA== Received: from [192.168.1.90] (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 08D3F17E0342; Mon, 26 Jan 2026 19:52:45 +0100 (CET) Message-ID: <6de0071f-a442-44b3-9ba2-13271cb1f246@collabora.com> Date: Mon, 26 Jan 2026 20:52:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/4] drm/rockchip: vop2: Support setting custom background color To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Robert Mader , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20251219-rk3588-bgcolor-v4-0-2ff1127ea757@collabora.com> <20251219-rk3588-bgcolor-v4-4-2ff1127ea757@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Nícolas, On 1/26/26 8:30 PM, Nícolas F. R. A. Prado wrote: > On Fri, 2025-12-19 at 23:47 +0200, Cristian Ciocaltea wrote: >> The Rockchip VOP2 display controller allows configuring the >> background >> color of each video output port. >> >> Since a previous patch introduced the BACKGROUND_COLOR CRTC property, >> which defaults to solid black, make use of it when programming the >> hardware. >> >> Note the maximum precision allowed by the display controller is >> 10bpc, >> while the alpha component is not supported, hence ignored. >> >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 13 ++++++++++++- >> drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 4 ++++ >> 2 files changed, 16 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >> b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >> index 498df0ce4680..3a232d0d4acb 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >> @@ -1554,6 +1554,7 @@ static void vop2_post_config(struct drm_crtc >> *crtc) >> struct vop2_video_port *vp = to_vop2_video_port(crtc); >> struct vop2 *vop2 = vp->vop2; >> struct drm_display_mode *mode = &crtc->state->adjusted_mode; >> + u64 bgcolor = crtc->state->background_color; >> u16 vtotal = mode->crtc_vtotal; >> u16 hdisplay = mode->crtc_hdisplay; >> u16 hact_st = mode->crtc_htotal - mode->crtc_hsync_start; >> @@ -1599,7 +1600,11 @@ static void vop2_post_config(struct drm_crtc >> *crtc) >> vop2_vp_write(vp, RK3568_VP_POST_DSP_VACT_INFO_F1, >> val); >> } >> >> - vop2_vp_write(vp, RK3568_VP_DSP_BG, 0); >> + /* Background color is programmed with 10 bits of precision >> */ >> + val = FIELD_PREP(RK3568_VP_DSP_BG__DSP_BG_RED, >> DRM_ARGB64_GETR(bgcolor) >> 6); >> + val |= FIELD_PREP(RK3568_VP_DSP_BG__DSP_BG_GREEN, >> DRM_ARGB64_GETG(bgcolor) >> 6); >> + val |= FIELD_PREP(RK3568_VP_DSP_BG__DSP_BG_BLUE, >> DRM_ARGB64_GETB(bgcolor) >> 6); > > Why aren't the DRM_ARGB64_GET*_BPC() helpers used here to get the > values with a custom precision? That's for performance reasons, please see "Changes in v4" section in the cover letter. I should have probably added a comment here (noted for v5). Thanks for the review! Regards, Cristian