From: Krzysztof Kozlowski <krzk@kernel.org>
To: Stone Zhang <quic_stonez@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_miaoqing@quicinc.com,
quic_zhichen@quicinc.com, quic_yuzha@quicinc.com
Subject: Re: [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride
Date: Mon, 10 Feb 2025 16:24:18 +0100 [thread overview]
Message-ID: <6de33406-04f0-4182-9ada-c41092fbded9@kernel.org> (raw)
In-Reply-To: <20250210062910.3618336-3-quic_stonez@quicinc.com>
On 10/02/2025 07:29, Stone Zhang wrote:
> Enable WLAN on qcs8300-ride by adding a node for the PMU module
> of the WCN6855 and assigning its LDO power outputs to the existing
> WiFi module.
>
> Signed-off-by: Stone Zhang <quic_stonez@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 96 +++++++++++++++++++++++
> 1 file changed, 96 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index c4c0db6f8b31..84c9e74ea4c9 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -22,6 +22,76 @@ aliases {
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + vreg_conn_1p8: vreg_conn_1p8 {
Follow DTS coding style and recommended naming for regulator.
You just shipped to us your downstream code. NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-10 15:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 6:29 [PATCH 0/2] Enable WLAN for qcs8300-ride Stone Zhang
2025-02-10 6:29 ` [PATCH 1/2] arm64: dts: qcom: qcs8300: add a PCIe port for WLAN Stone Zhang
2025-02-10 6:29 ` [PATCH 2/2] arm64: dts: qcom: qcs8300-ride: enable WLAN on qcs8300-ride Stone Zhang
2025-02-10 15:24 ` Krzysztof Kozlowski [this message]
2025-02-10 16:24 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de33406-04f0-4182-9ada-c41092fbded9@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_miaoqing@quicinc.com \
--cc=quic_stonez@quicinc.com \
--cc=quic_yuzha@quicinc.com \
--cc=quic_zhichen@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox