From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: rouven.czerwinski@linaro.org,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: verisilicon: remove hantro_run declaration
Date: Wed, 29 Apr 2026 15:01:47 -0400 [thread overview]
Message-ID: <6dfaacd9cd8d3acb9335618f14acdb8f4a42e5c8.camel@collabora.com> (raw)
In-Reply-To: <20260410-hantro-dangling-declaration-v1-1-9a5cd401e1e8@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
Le vendredi 10 avril 2026 à 08:15 +0200, Rouven Czerwinski via B4 Relay a
écrit :
> From: Rouven Czerwinski <rouven.czerwinski@linaro.org>
>
> The function hantro_run() is declared but never defined nor used, remove
> the dangling declaration.
>
> Signed-off-by: Rouven Czerwinski <rouven.czerwinski@linaro.org>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> drivers/media/platform/verisilicon/hantro_hw.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/verisilicon/hantro_hw.h
> b/drivers/media/platform/verisilicon/hantro_hw.h
> index 5f2011529f02..13e573f1f19d 100644
> --- a/drivers/media/platform/verisilicon/hantro_hw.h
> +++ b/drivers/media/platform/verisilicon/hantro_hw.h
> @@ -427,7 +427,6 @@ extern const struct hantro_postproc_ops
> rockchip_vpu981_postproc_ops;
> extern const u32 hantro_vp8_dec_mc_filter[8][6];
>
> void hantro_watchdog(struct work_struct *work);
> -void hantro_run(struct hantro_ctx *ctx);
> void hantro_irq_done(struct hantro_dev *vpu,
> enum vb2_buffer_state result);
> void hantro_start_prepare_run(struct hantro_ctx *ctx);
>
> ---
> base-commit: 591cd656a1bf5ea94a222af5ef2ee76df029c1d2
> change-id: 20260409-hantro-dangling-declaration-a337df1daf42
>
> Best regards,
> --
> Rouven Czerwinski <rouven.czerwinski@linaro.org>
>
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-04-29 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 6:15 [PATCH] media: verisilicon: remove hantro_run declaration Rouven Czerwinski via B4 Relay
2026-04-29 19:01 ` Nicolas Dufresne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dfaacd9cd8d3acb9335618f14acdb8f4a42e5c8.camel@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rouven.czerwinski@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox