From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD0FAC432C0 for ; Fri, 29 Nov 2019 15:43:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4C1121736 for ; Fri, 29 Nov 2019 15:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727005AbfK2Pnl (ORCPT ); Fri, 29 Nov 2019 10:43:41 -0500 Received: from mga04.intel.com ([192.55.52.120]:9295 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726917AbfK2Pnl (ORCPT ); Fri, 29 Nov 2019 10:43:41 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 07:43:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,257,1571727600"; d="scan'208";a="234741289" Received: from linux.intel.com ([10.54.29.200]) by fmsmga004.fm.intel.com with ESMTP; 29 Nov 2019 07:43:40 -0800 Received: from [10.252.8.148] (abudanko-mobl.ccr.corp.intel.com [10.252.8.148]) by linux.intel.com (Postfix) with ESMTP id 64FD85802B9; Fri, 29 Nov 2019 07:43:37 -0800 (PST) Subject: Re: [PATCH v3 2/3] perf mmap: declare type for cpu mask of arbitrary length To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , Andi Kleen , linux-kernel References: <908dbe98-7d8d-0ec1-d4ae-242f3e104979@linux.intel.com> <446c4345-cb20-d0ad-3b3d-b34683b1c1e0@linux.intel.com> <20191129130946.GC14169@krava> From: Alexey Budankov Organization: Intel Corp. Message-ID: <6dfdfba5-88b7-067b-855b-8f5f7bbc8043@linux.intel.com> Date: Fri, 29 Nov 2019 18:43:35 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191129130946.GC14169@krava> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.11.2019 16:09, Jiri Olsa wrote: > On Fri, Nov 29, 2019 at 01:04:37PM +0300, Alexey Budankov wrote: >> >> Declare a dedicated struct map_cpu_mask type for cpu masks of >> arbitrary length. Mask is available thru bits pointer and the >> mask length is kept in nbits field. MMAP_CPU_MASK_BYTES() macro >> returns mask storage size in bytes. perf_mmap__print_cpu_mask() >> function can be used to log text representation of the mask. >> >> Signed-off-by: Alexey Budankov >> --- >> tools/perf/util/mmap.c | 12 ++++++++++++ >> tools/perf/util/mmap.h | 11 +++++++++++ >> 2 files changed, 23 insertions(+) >> >> diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c >> index 063d1b93c53d..30ff7aef06f2 100644 >> --- a/tools/perf/util/mmap.c >> +++ b/tools/perf/util/mmap.c >> @@ -23,6 +23,18 @@ >> #include "mmap.h" >> #include "../perf.h" >> #include /* page_size */ >> +#include >> + >> +#define MASK_SIZE 1023 >> +void perf_mmap__print_cpu_mask(struct mmap_cpu_mask *mask, const char *tag) > > 'mmap_cpu_mask__scnprintf' name follows the name logic we try to use Renamed in v4. Thanks, Alexey > > jirka > >> +{ >> + char buf[MASK_SIZE + 1]; >> + size_t len; >> + >> + len = bitmap_scnprintf(mask->bits, mask->nbits, buf, MASK_SIZE); >> + buf[len] = '\0'; >> + pr_debug("%p: %s mask[%ld]: %s\n", mask, tag, mask->nbits, buf); >> +} >> >> size_t mmap__mmap_len(struct mmap *map) >> { >> diff --git a/tools/perf/util/mmap.h b/tools/perf/util/mmap.h >> index bee4e83f7109..598e2def8a48 100644 >> --- a/tools/perf/util/mmap.h >> +++ b/tools/perf/util/mmap.h >> @@ -15,6 +15,15 @@ >> #include "event.h" >> >> struct aiocb; >> + >> +struct mmap_cpu_mask { >> + unsigned long *bits; >> + size_t nbits; >> +}; >> + >> +#define MMAP_CPU_MASK_BYTES(m) \ >> + (BITS_TO_LONGS(((struct mmap_cpu_mask *)m)->nbits) * sizeof(unsigned long)) >> + >> /** >> * struct mmap - perf's ring buffer mmap details >> * >> @@ -52,4 +61,6 @@ int perf_mmap__push(struct mmap *md, void *to, >> >> size_t mmap__mmap_len(struct mmap *map); >> >> +void perf_mmap__print_cpu_mask(struct mmap_cpu_mask *mask, const char *tag); >> + >> #endif /*__PERF_MMAP_H */ >> -- >> 2.20.1 >> > >