From: Andrew Lunn <andrew@lunn.ch>
To: Paul SAGE <paul.sage@42.fr>
Cc: vinc@42.fr, Pavan Chebbi <pavan.chebbi@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tg3: replace placeholder MAC address with device property
Date: Thu, 23 Oct 2025 21:05:52 +0200 [thread overview]
Message-ID: <6e1641fe-e681-414e-bd51-e20cf511f85a@lunn.ch> (raw)
In-Reply-To: <20251023160946.380127-1-paul.sage@42.fr>
On Thu, Oct 23, 2025 at 06:08:42PM +0200, Paul SAGE wrote:
> On some systems (e.g. iMac 20,1 with BCM57766), the tg3 driver reads a default placeholder mac address (00:10:18:00:00:00) from the mailbox.
> The correct value on those systems are stored in the 'local-mac-address' property.
Is this the DT property? I don't see any compatible in tg.c, so it is
not clear to me how this driver gets probed.
Also, please wrap the commit message to around 70 characters.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-10-23 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 16:08 [PATCH] tg3: replace placeholder MAC address with device property Paul SAGE
2025-10-23 17:14 ` Florian Fainelli
2025-10-23 19:05 ` Andrew Lunn [this message]
2025-10-27 9:51 ` Andrew Lunn Paul SAGE
2025-10-27 13:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e1641fe-e681-414e-bd51-e20cf511f85a@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.sage@42.fr \
--cc=pavan.chebbi@broadcom.com \
--cc=vinc@42.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox