From: Johannes Berg <johannes@sipsolutions.net>
To: Nikita Aleksandrov <n.aleksandrovuk@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+e55106f8389651870be0@syzkaller.appspotmail.com
Subject: Re: [PATCH] mac80211: tdls: don't WARN_ON_ONCE on missing STA info
Date: Sun, 26 Oct 2025 11:34:02 +0100 [thread overview]
Message-ID: <6e179c1004ca0fe033cc728bbced0e2ddf301f49.camel@sipsolutions.net> (raw)
In-Reply-To: <20251026102553.29195-1-N.Aleksandrovuk@gmail.com> (sfid-20251026_112820_017068_8FCE0C8E)
On Sun, 2025-10-26 at 10:25 +0000, Nikita Aleksandrov wrote:
> syzbot report e55106f8389651870be0 revealed a crash in tdls handling
> when the STA or AP STA info was missing.
> Fix: replace WARN_ON_ONCE with a regular error log (sdata_err) and
> return early if STA info is missing. Avoids panic_on_warn.
>
Wrong way to do this, we shouldn't get here that way.
johannes
prev parent reply other threads:[~2025-10-26 10:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 10:25 [PATCH] mac80211: tdls: don't WARN_ON_ONCE on missing STA info Nikita Aleksandrov
2025-10-26 10:34 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e179c1004ca0fe033cc728bbced0e2ddf301f49.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=n.aleksandrovuk@gmail.com \
--cc=syzbot+e55106f8389651870be0@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox