From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF4D318026; Mon, 8 Apr 2024 06:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712559003; cv=none; b=kcRpT7nX+AxkqiUbIu/igiBuVcpfBpQe9cWXOf7mzOHj0fU5GgKpmBCl4OXpF64iQNwTbPkG0KNuW8bS7DdhslQnFSZy/yFVaNPRu6J/KZp6+04kpkUFrjjdBOSoeDM2sAxgI3TekU5Nm5vQ74vjpTvOBZ3X+0S5vDchYQ619oY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712559003; c=relaxed/simple; bh=+5HCfq5uK8y7rOB5VKTxwaht8j5UlBg/L7xDpwpFvFU=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:To:Date; b=qBkbmNkOWK2ekLxL83WXFZIe30XgqP7snnKUblkjX5omkZtc5f/md3VBcxcnOZ2VtA49MZeKoiG9NOPeX5MD2zwQQa4Ve1UUK046NxhgacWrDzTZrlPGCyKlR/sqpyUNvGD7TobzXjqaamK7M3kBJdmQSQIUrvLJ5HqRarzhq1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QMZZlJQP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QMZZlJQP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54743C433F1; Mon, 8 Apr 2024 06:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712559003; bh=+5HCfq5uK8y7rOB5VKTxwaht8j5UlBg/L7xDpwpFvFU=; h=In-Reply-To:References:Subject:From:To:Date:From; b=QMZZlJQPcbxI6rLSJoLYM7+1EiE4Yc56PsWcKu10aGZRrJ20HZBv0Ut7uW2oGwrNz 01kIAyLirLsfv84XHi55FpSU5LiG0At+KOsSPol/yaqA9jdO1/9CixUGR/nMXomixi VVTSLGAa436AHH/wWClW1kL7Quh3AASTcSLH/vs7/yCicGSqLtqto/P3zzwHtJkTbo 7IY99e7qFRcBAD0jWjN+uUbGfJUtPGi3KXFYXKEc5vy01D64Z5bHtU2wNgXgMqaqig OrNDdWgFtS/P1XOzoFPvULIIYr+5zLVYHQ8eBJUxQopuCerLBIo/8pMUeYOt1HX9td +WxQdG8lGP2NQ== Message-ID: <6e2934870cc523f26953a856dc454441.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <1da2506a51f970706bf4ec9509dd04e0471065e5.1710367453.git.daniel@makrotopia.org> Subject: Re: [PATCH] clk: mediatek: mt7988-infracfg: fix clocks for 2nd PCIe port From: Stephen Boyd To: AngeloGioacchino Del Regno , Daniel Golle , Frank Wunderlich , Matthias Brugger , Michael Turquette , Sam Shih , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Date: Sun, 07 Apr 2024 23:50:01 -0700 User-Agent: alot/0.10 Quoting AngeloGioacchino Del Regno (2024-03-14 02:44:59) > Il 13/03/24 23:05, Daniel Golle ha scritto: > > Due to what seems to be an undocumented oddity in MediaTek's MT7988 > > SoC design the CLK_INFRA_PCIE_PERI_26M_CK_P2 clock requires > > CLK_INFRA_PCIE_PERI_26M_CK_P3 to be enabled. > >=20 > > This currently leads to PCIe port 2 not working in Linux. > >=20 > > Reflect the apparent relationship in the clk driver to make sure PCIe > > port 2 of the MT7988 SoC works. > >=20 > > Fixes: 4b4719437d85f ("clk: mediatek: add drivers for MT7988 SoC") > > Suggested-by: Sam Shih > > Signed-off-by: Daniel Golle >=20 > That's funny. Anyway: >=20 > Reviewed-by: AngeloGioacchino Del Regno Are you picking up mediatek clk patches and fixes this cycle?