From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dmitry Vyukov <dvyukov@google.com>,
syzbot <syzbot+e9f364d3b15ce41d8451@syzkaller.appspotmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
David Miller <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev <netdev@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: INFO: rcu detected stall in llcp_sock_sendmsg
Date: Mon, 9 Jul 2018 14:05:08 -0700 [thread overview]
Message-ID: <6e2e4cfa-2cde-ec28-933d-1ee17c8b1da9@gmail.com> (raw)
In-Reply-To: <CACT4Y+Zc+UKpGwEEMfKOsZ1s+AAFYFrVmjO0-u7NNjODRiJ7tg@mail.gmail.com>
On 07/09/2018 01:50 PM, Dmitry Vyukov wrote:
> On Mon, Jul 9, 2018 at 10:34 PM, syzbot
> <syzbot+e9f364d3b15ce41d8451@syzkaller.appspotmail.com> wrote:
>> Hello,
>>
>> syzbot found the following crash on:
>>
>> HEAD commit: 1e4b044d2251 Linux 4.18-rc4
>> git tree: upstream
>> console output: https://syzkaller.appspot.com/x/log.txt?x=1414c2c2400000
>> kernel config: https://syzkaller.appspot.com/x/.config?x=25856fac4e580aa7
>> dashboard link: https://syzkaller.appspot.com/bug?extid=e9f364d3b15ce41d8451
>> compiler: gcc (GCC) 8.0.1 20180413 (experimental)
>>
>> Unfortunately, I don't have any reproducer for this crash yet.
>>
>> IMPORTANT: if you fix the bug, please add the following tag to the commit:
>> Reported-by: syzbot+e9f364d3b15ce41d8451@syzkaller.appspotmail.com
>
> Looks like the problem is actually in nfc, so +nfc maintainers.
Note this issue was discussed before, maybe we should patch NFC without waiting for nfc maintainer.
----------------------------------------------------
On 06/25/2018 10:12 PM, Sergey Senozhatsky wrote:
> On (06/26/18 07:07), Dmitry Vyukov wrote:
> [..]
>>> #include <net/nfc/nfc.h>
>>> @@ -755,7 +756,8 @@ int nfc_llcp_send_ui_frame(struct nfc_llcp_sock *sock, u8 ssap, u8 dsap,
>>> pdu = nfc_alloc_send_skb(sock->dev, &sock->sk, MSG_DONTWAIT,
>>> frag_len + LLCP_HEADER_SIZE, &err);
>>> if (pdu == NULL) {
>>> - pr_err("Could not allocate PDU\n");
>>> + pr_err_ratelimited("Could not allocate PDU\n");
>>> + cond_resched();
>>> continue;
>>> }
>>
>>
>> But this thread is still in an infinite (unkillable?) loop? If yes, we
>> are waiting for the next syzbot report
>
> The loop is still infinite, correct, but we have a preemption point now.
> Sure, net people can come with a much better solution, I'll be happy to
> scratch my patch.
>
This can not be the right solution, think about current thread being real time,
cond_resched() might be a nop.
We should probably not loop at all, or not use MSG_DONTWAIT.
(And remove this useless "Could not allocate PDU" message)
NFC maintainers should really take a look at this.
next prev parent reply other threads:[~2018-07-09 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 20:34 INFO: rcu detected stall in llcp_sock_sendmsg syzbot
2018-07-09 20:50 ` Dmitry Vyukov
2018-07-09 21:05 ` Eric Dumazet [this message]
2018-07-10 10:55 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e2e4cfa-2cde-ec28-933d-1ee17c8b1da9@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sameo@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=syzbot+e9f364d3b15ce41d8451@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox