From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D28027EFE9 for ; Thu, 19 Mar 2026 05:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773899394; cv=none; b=HNDUuyPYmahnxBu/Z4PJrmqYvRa7f7y/G83lpBHm1LEYTqqEJq5hqiB1+xPl9tp/Jqw3bM1wQRd18OnbVTu5toevXxgwS8ngR76zF7KnLlUsTI9M2meHc1tEP6BypJY461Uv+jLyWJ55LxaHJwc9f0NQyPCFc7vso+x2fTQoRdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773899394; c=relaxed/simple; bh=IPNmg/QAX7oGxoUC4oxWan2FFCT85H4qf7WyrH8Pgnk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sBEb4MvP35DpZyY0kdtcmWAi7ZWXz5+kmThq+81Y4wu+zLw8ivSDhJRszR72v9P5USXTw2UuCO0vmzC4OyPZGbBcUdRTgBYjW4gujoXK941qPkqti2HTMffr+YuhmarSBHKMy762haHeYlyUpIri1W/5Y8Sq1s784PO0WruzL3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RhHKaTJ4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Svu5oW39; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RhHKaTJ4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Svu5oW39" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J5Xcah573835 for ; Thu, 19 Mar 2026 05:49:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pnlY8HB3yDdOi+HU00GrZcKC7F6O3XJWo7Y53P6upBA=; b=RhHKaTJ4QUXHgzIZ FRSSpEqYtBx140tZHNarzUC2dd8jzP8pCn9frm9c1BoHT8g6mfqsZ82Anejuwlpp MWb0hCHL1TyAFrA1fypAhM1YtcEtC1zBaB8VhnnjOraftvTq1u0C8QX2EY4Aa4ks 2hHsA/jg0Phzs89utm4ONnJE7g5kVK30qG4KgNcm7r2WLguAgQQryH6CtVZztCNC 7VsFsxVAMNNmOqnoHTSXtJTk29ywPVUpJB07J9JICpYYuloorCgsXyCzGArr5/5Q S+q7YvlDbzrDA1puMxyKoxBwD3FWa87kmxBEuK0v+5m5k714Mpl4WxXephxveaXA +LeBXA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d00eg9x3b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 05:49:52 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b06395b7a7so7943685ad.2 for ; Wed, 18 Mar 2026 22:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773899392; x=1774504192; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pnlY8HB3yDdOi+HU00GrZcKC7F6O3XJWo7Y53P6upBA=; b=Svu5oW39F//jO9oD6M6LMxbP1c4qEnNiXd7kD6izz60dzXNZZT8vl48/cLbOGLlgSt GeJCG0MOae81Hts0tm4tMXSESzBZ78MsiFBj1dew2ahpEOtU0X7GezFX/eokMzgSSFZT 5WbCOGX+iy3K9wXLgG0hPgS1NjxeYWTGi2/MFFSK7uI8w81mrqOKdHHAw+RAfhnrlQpk F6vVb1bUmhmRvAnegtexWU9XekT6d48kNilXUhDiL3tpFvRVMRgsFTt4TnbdoDvYSOnj jyF3hnTX2lBg1xQYnWjfjqZ/J5Lp0aqxGcEN2fST/Dq2evOFOI5UdTa58sF5KIFiJIzH zKOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773899392; x=1774504192; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pnlY8HB3yDdOi+HU00GrZcKC7F6O3XJWo7Y53P6upBA=; b=Vsfu3L7rRQ6Je8oDUKA/GdDBkzWVy5ZVii2PR7Sk+H+0Yu/UBPGf4mbnqHgZS+p6Vb qEMhkazvRQrj0n58jQi0U/pBTeXx3GD9WL5MqkUedgObZe2bn8dhB9como1XwF3ENZIy UBc8P0rw2kdz+oySRu2aH1wyE37UuFU7rf4vm3d+YXiIuvIL7dioVHXYM0jpuFh29CAr w+mDDlg1KvNKZ8DLrvX+WALyzgpMt4+3/sDIOhsUynFfTiwV7vUkpoieEP7IgzmW+dlu CysH+CohV5nHQfclNniMLroOjcFxp8QLXnvDgvBW09NDeD6il3YXZjNfw2g7jUWU9U3X 0Oug== X-Forwarded-Encrypted: i=1; AJvYcCVrJajbknfR1ZsIh5EK0AuaK9GewmMI75u9if6F2Gksv1pQeOUhOFOuDeosWKHv3VPoKTUB+g8ZjMXpgx4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl8/bGxNorrVDIC45s17yB1D7iTTHexw2HBl1tgqtj+uRzC33M P7h/y2AjnpcRhy3YG4XNJJFmG3OOLTZ+Qg9y0YkNrmrE9quGiG7I8D2kok0TeSLjv0sZFWBgYF5 r7EiSo3EctKDT3CEDbTFsmm3ZoQ0yiM0lHDhIv1XxuCBqysAIzTd8Wzo8n/zlw191GaM= X-Gm-Gg: ATEYQzwZRViEdWz2GRlt/6CtSy5lphpE2PgAZWUMC95Kx5a3qZm6jgiZLpkmSfrxL4n WX+MThoJOereYf4ohzzrau56swmKFObOZzawmJUctQe1mbjSFEhYF46oiCkmJuXeUZHNgZmVjyT Aq8MuE0CdVAk93PmvE38hIr5/Y1Jnjjxpypej+QtekHrzbs0Vbyoougb1l05lAGmc0MO/O4rMsK IIsBu78XhFFl06W7H0o31BnkQyYai1nV+eRjdSH6C7wF8ki4IHPHwby6vR0k/2LUFZDx/J+6wbf B44nYaJQRAG6Xtd/ZqZGiTlTO9K7rNt4oW+NR+xDw0USVX31guO63QqGQl8IGOz7CXmIR6d9+D4 Conj802jN0S021NzWeuMJpeqxzI34keyvAcBKH1/ARgRrRuVUKZfsyXVdd7OhjRMN9CyAjPKqRA YiRNrT0HLRvQ== X-Received: by 2002:a17:902:ef08:b0:2b0:6621:cedd with SMTP id d9443c01a7336-2b06e4319d3mr68941095ad.49.1773899391965; Wed, 18 Mar 2026 22:49:51 -0700 (PDT) X-Received: by 2002:a17:902:ef08:b0:2b0:6621:cedd with SMTP id d9443c01a7336-2b06e4319d3mr68940915ad.49.1773899391519; Wed, 18 Mar 2026 22:49:51 -0700 (PDT) Received: from [10.133.33.84] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e44a42esm46352395ad.33.2026.03.18.22.49.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 22:49:51 -0700 (PDT) Message-ID: <6e2f03ee-6cde-48ea-9f43-6b911117fe4b@oss.qualcomm.com> Date: Thu, 19 Mar 2026 13:49:45 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 04/12] scsi: ufs: core: Add support for TX Equalization To: =?UTF-8?B?UGV0ZXIgV2FuZyAo546L5L+h5Y+LKQ==?= , "beanhuo@micron.com" , "mani@kernel.org" , "avri.altman@wdc.com" , "bvanassche@acm.org" , "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "adrian.hunter@intel.com" , "alim.akhtar@samsung.com" , "James.Bottomley@HansenPartnership.com" , "quic_nguyenb@quicinc.com" , "linux-kernel@vger.kernel.org" References: <20260308151409.3779137-1-can.guo@oss.qualcomm.com> <20260308151409.3779137-5-can.guo@oss.qualcomm.com> <42587e16218f1c51dbcbe6bb1639a843e10bcd80.camel@mediatek.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=MMNtWcZl c=1 sm=1 tr=0 ts=69bb8e80 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=lZOxv685zBznO1DyOMIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: D7d7fO_-QMsD8D0o2vA3LVCCRQ8BLG7X X-Proofpoint-GUID: D7d7fO_-QMsD8D0o2vA3LVCCRQ8BLG7X X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDA0MiBTYWx0ZWRfX/In++w6M8lnv TQVMcz7YCdVycKMfASieMbj0fK09o43JKxGEP5+VdITGkdKsEJ955rXHWk/TGu9BjdnGEbPyb+T BnDuz2u2o5MHVriffWMZYvcCkJhKUufvahm/zCmFRm+SMLSiE8junaa1IhibHX+7ZTgLAvDipzT weXS8+oP++Zdujr2Mny9t5gG5fDJVWgd0q1M5lu+N9LVeDqp4M9ir+73V8ksJ8oDDRv1GK7o1ts 8f259TRaRcYfqMkWUMi+OgD8RykX/mcJaEUSdEUBQfSTTCAal65x41UKMhz0rjsJ4+w886TQG/E MAbo9o17dgmfYe4JCJxbTKWR1BKzsHYmCpWAIvf5fYyLN0LnIjoI+GaLNtuhUgOd2hNnE8ZRVJi Evl4C1vlvddozX/2rslIMp7Fly+KyG2SoCmTEMvT9j0ZwdAFRv+jM2+lWoZBwygEFL+MSdGGVDa NqXJd9AQzU5vF3r3tKw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 phishscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190042 On 3/17/2026 9:10 PM, Peter Wang (王信友) wrote: > > On Tue, 2026-03-17 at 15:35 +0800, Can Guo wrote: > > The main data struct which is costing memory is the TX EQTR record > > arrays, I can optimize > > in next very by dynamically allocating memory ONLY for the Gears > > which > > actually > > need TX EQTR. > > > > Thanks, > > Can Guo. > > > > > Hi Can, > > It's not just Gear that needs to be considered, lane count does > as well. Only allocate the Gear and lane numbers that actually > require EQTR. Also, please optimize the structure, for variables > that only need UINT8, don't use UINT32, since memory usage is four > times greater. Sure, for the lanes too. But I will still keep FOM records as u16, because we need to initialize it to a default value other than 0x0 to 0xFF such that we can differentiate a real FOM value (unit 8, read from RX_FOM) from the default one. Thanks, Can Guo. > > Thanks > Peter > > ************* MEDIATEK Confidentiality Notice ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you!