From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E941AC3527C for ; Mon, 21 Feb 2022 10:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354275AbiBUKMV (ORCPT ); Mon, 21 Feb 2022 05:12:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353582AbiBUKGb (ORCPT ); Mon, 21 Feb 2022 05:06:31 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6E4622611E for ; Mon, 21 Feb 2022 01:31:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645435887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M7GipAFivLru7/FXCZ9Ov73kX45whBG6hrjha1HlyIU=; b=TWFVldRaAzNni9Bl3hNupI7fRmdZmY44TycxJ++WYXL+TCVFumoKO1cBgNfEfrWEzJLemY D3fFfDtUwVNCwD65LovTS5KLGRUb8o7VjYNX3NWaEWA65gHmELPzzXCX6Wi1uOHBsv7RUl IQX/a7CxtSm5cwYk95cBjEGwXyFRoO4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-314-nqE3mU-TM1OCMZzFt6XEeA-1; Mon, 21 Feb 2022 04:31:25 -0500 X-MC-Unique: nqE3mU-TM1OCMZzFt6XEeA-1 Received: by mail-wm1-f70.google.com with SMTP id i30-20020a1c541e000000b0037dbf3d7efdso1719863wmb.4 for ; Mon, 21 Feb 2022 01:31:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=M7GipAFivLru7/FXCZ9Ov73kX45whBG6hrjha1HlyIU=; b=wvPFnFgb8BExilEFblst+QWSpuiZYdjcMHjk67BF/9HwxwNMy5BeAGYbLrbqflje+F ZZrKVPADoPRcXiY8O/l7hoGaZ6yb6HDKxfi+gsNQ2EaClxWpd81tW4QmpOzkAYZ+VwDC 6egqnwNDUg4Iuu1PJDIhcj/IcggH7reFrex9Fo85CQ8EPaBg99E7dX84epynWI7kn/Gt g5H4AROgHZql+n2fTQdgPCDfwhr0cNNYw/Oci7RKD7FcHc+yTXMfNkK3UPVTxheTvdZi uBQoyXO5+t6p1emEmymvQe95qgMnsQ8y7RnovAVLw3rxG9hI4qr/msczIsO0nota1254 xgiA== X-Gm-Message-State: AOAM530VUA2myYxVz8UXTSzZ3njRex2woEy3WH/i6P5EM1s5IBGaTLa5 59ze4JhdZPY+WHNHgtZWK963hxMUnqe8gGIbf0Ia607nFfegp+rdn9HYgfCXtN4rSSxwJnQ2tUI MRG50xRCMoA6pqyWBdfJABaqr X-Received: by 2002:a5d:598f:0:b0:1e3:649:e6c3 with SMTP id n15-20020a5d598f000000b001e30649e6c3mr15091391wri.520.1645435884410; Mon, 21 Feb 2022 01:31:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHT0HMNxoGY/7w7S9Z2qpMPtCIP1DkecWzMXFUa68IRpPrLRiHR5foft4LM7SrrciDM7n/aw== X-Received: by 2002:a5d:598f:0:b0:1e3:649:e6c3 with SMTP id n15-20020a5d598f000000b001e30649e6c3mr15091376wri.520.1645435884162; Mon, 21 Feb 2022 01:31:24 -0800 (PST) Received: from [10.33.192.232] (nat-pool-str-t.redhat.com. [149.14.88.106]) by smtp.gmail.com with ESMTPSA id h15-20020a05600c350f00b0037d1e31a25csm7094078wmq.26.2022.02.21.01.31.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 01:31:23 -0800 (PST) Message-ID: <6e5acc94-4459-2385-331f-501d47106a20@redhat.com> Date: Mon, 21 Feb 2022 10:31:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] selftests: kvm: Check whether SIDA memop fails for normal guests Content-Language: en-US To: Shuah Khan , Christian Borntraeger , Janosch Frank , kvm@vger.kernel.org Cc: David Hildenbrand , Claudio Imbrenda , Paolo Bonzini , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220215074824.188440-1-thuth@redhat.com> From: Thomas Huth In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/02/2022 16.25, Shuah Khan wrote: > On 2/15/22 12:48 AM, Thomas Huth wrote: >> Commit 2c212e1baedc ("KVM: s390: Return error on SIDA memop on normal >> guest") fixed the behavior of the SIDA memops for normal guests. It >> would be nice to have a way to test whether the current kernel has >> the fix applied or not. Thus add a check to the KVM selftests for >> these two memops. >> >> Signed-off-by: Thomas Huth >> --- >>   tools/testing/selftests/kvm/s390x/memop.c | 15 +++++++++++++++ >>   1 file changed, 15 insertions(+) >> >> diff --git a/tools/testing/selftests/kvm/s390x/memop.c >> b/tools/testing/selftests/kvm/s390x/memop.c >> index 9f49ead380ab..d19c3ffdea3f 100644 >> --- a/tools/testing/selftests/kvm/s390x/memop.c >> +++ b/tools/testing/selftests/kvm/s390x/memop.c >> @@ -160,6 +160,21 @@ int main(int argc, char *argv[]) >>       run->psw_mask &= ~(3UL << (63 - 17));   /* Disable AR mode */ >>       vcpu_run(vm, VCPU_ID);                  /* Run to sync new state */ >> +    /* Check that the SIDA calls are rejected for non-protected guests */ >> +    ksmo.gaddr = 0; >> +    ksmo.flags = 0; >> +    ksmo.size = 8; >> +    ksmo.op = KVM_S390_MEMOP_SIDA_READ; >> +    ksmo.buf = (uintptr_t)mem1; >> +    ksmo.sida_offset = 0x1c0; >> +    rv = _vcpu_ioctl(vm, VCPU_ID, KVM_S390_MEM_OP, &ksmo); >> +    TEST_ASSERT(rv == -1 && errno == EINVAL, >> +            "ioctl does not reject SIDA_READ in non-protected mode"); > > Printing what passed would be a good addition to understand the tests that > get run and expected to pass. Yes, I agree ... I'll add that for a follow-up patch to my TODO list. >> +    ksmo.op = KVM_S390_MEMOP_SIDA_WRITE; >> +    rv = _vcpu_ioctl(vm, VCPU_ID, KVM_S390_MEM_OP, &ksmo); >> +    TEST_ASSERT(rv == -1 && errno == EINVAL, >> +            "ioctl does not reject SIDA_WRITE in non-protected mode"); >> + > > Same here. > >>       kvm_vm_free(vm); >>       return 0; >> > > Something to consider in a follow-on patch and future changes to these tests. > > Reviewed-by: Shuah Khan Thanks! Thomas