From: Jeff Layton <jlayton@kernel.org>
To: Li zeming <zeming@nfschina.com>,
chuck.lever@oracle.com, trond.myklebust@hammerspace.com,
anna@kernel.org
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sunrpc: svc: Remove unnecessary (void*) conversions
Date: Thu, 03 Nov 2022 05:43:55 -0400 [thread overview]
Message-ID: <6e67efff3f5f72d7bcdf90b972cd758e0e98e853.camel@kernel.org> (raw)
In-Reply-To: <20221103013510.3062-1-zeming@nfschina.com>
On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote:
> The iov_base pointer does not need to cast the type.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> include/linux/sunrpc/svc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..4b0eead91c94 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)
>
> static inline void svc_ungetu32(struct kvec *iov)
> {
> - __be32 *vp = (__be32 *)iov->iov_base;
> + __be32 *vp = iov->iov_base;
> iov->iov_base = (void *)(vp - 1);
> iov->iov_len += sizeof(*vp);
> }
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2022-11-03 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 1:35 [PATCH] sunrpc: svc: Remove unnecessary (void*) conversions Li zeming
2022-11-03 9:43 ` Jeff Layton [this message]
2022-11-03 12:49 ` Trond Myklebust
2022-11-03 13:07 ` Chuck Lever III
2022-11-04 1:02 ` Li zeming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e67efff3f5f72d7bcdf90b972cd758e0e98e853.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox