From: Pratyush Brahma <quic_pbrahma@quicinc.com>
To: Kuldeep Singh <quic_kuldsing@quicinc.com>,
Bjorn Andersson <bjorn.andersson@example.com>,
Konrad Dybcio <konrad.dybcio@example.com>,
"Rob Herring" <rob.herring@example.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@example.com>,
Conor Dooley <conor.dooley@example.com>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_tengfan@quicinc.com>,
<quic_shashim@quicinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: qcs9100: Update memory map for QCS9100 Ride and QCS9100 Ride Rev3
Date: Wed, 20 Nov 2024 12:04:04 +0530 [thread overview]
Message-ID: <6e930d07-4b0b-422f-8435-b25ab14e585e@quicinc.com> (raw)
In-Reply-To: <30fda0e2-f314-49b8-8c1c-bf4fac87050d@quicinc.com>
On 11/20/2024 1:41 AM, Kuldeep Singh wrote:
>
> On 11/19/2024 2:55 PM, Pratyush Brahma wrote:
>> This patch series is based on Tengfei Fan's patches [1] which adds support
>> for QCS9100 Ride and QCS9100 Ride Rev3 boards.
>>
>> Some new carveouts (viz. gunyah_md and a few pil dtb carveouts) have been
>> introduced and the size and base addresses have been updated for
>> a few of existing carveouts compared to SA8775P. Also, tz_ffi_mem carveout
>> and its corresponding scm reference has been removed as it is not required
>> for these boards. Incorporate these changes in the updated memory map
>> for QCS9100 Ride and QCS9100 Rev3 boards.
>>
>> [1] https://lore.kernel.org/all/20240911-add_qcs9100_support-v2-4-e43a71ceb017@quicinc.com/
>>
>> Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com>
> The memory map for qcs9100-ride-r3 and qcs9100-ride is exactly same.
> A good churn you are first deleting(based on sa8775p) and then re-adding
> for qcs9100-ride*.
>
> I think it's better to move common qcs9100-ride* to a common file ex:
> qcs9100-ride.dtsi and keep specifics further to .dts files?
>
> This will ensure common entities are present at same place with no
> duplicates.
>
> --
>
> Regards
> Kuldeep
It is true that the memory map for qcs9100-ride.dts and
qcs9100-ride-r3.dts is exactly
the same. However, I am not sure if having a new common dtsi file would
be the right approach
here since qcs9100* dts files inherit the sa8775p.dtsi file already.
I'll wait for Bjorn's comment here.
--
Thanks and Regards
Pratyush Brahma
prev parent reply other threads:[~2024-11-20 6:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 9:25 [PATCH] arm64: dts: qcom: qcs9100: Update memory map for QCS9100 Ride and QCS9100 Ride Rev3 Pratyush Brahma
2024-11-19 13:32 ` Rob Herring (Arm)
2024-11-19 20:11 ` Kuldeep Singh
2024-11-20 6:34 ` Pratyush Brahma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e930d07-4b0b-422f-8435-b25ab14e585e@quicinc.com \
--to=quic_pbrahma@quicinc.com \
--cc=bjorn.andersson@example.com \
--cc=conor.dooley@example.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@example.com \
--cc=krzysztof.kozlowski@example.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kuldsing@quicinc.com \
--cc=quic_shashim@quicinc.com \
--cc=quic_tengfan@quicinc.com \
--cc=rob.herring@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox