From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18C4B3C5540 for ; Thu, 7 May 2026 14:48:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165294; cv=none; b=tp9RJSdbZVffv2MZXf7T5aoJ8p4ZzZlObtBBLdQi6QRULfNboUgwHRc41akQkj0E7OMc5gBzKFIVqU1IJDlr92jRW8B6/uQRcQfSFrHQrtL5UyGbKzwXnMNUx7pVWeCwQL+Vm8bXoNQY+hgEMa3k21VSNaZo1xC6BPwhfbxFC0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165294; c=relaxed/simple; bh=doSKqAywgZG0zfP01dCotawEVBqSKyhp7tUDohMKP/I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UVqKfCEqa+2duhQxA1qIGZJOvOmOtFi8R3MNTc1nl2X/EHYp2HZ3xYzMgR3hr0nrKc/X3VXPTmzCZrXAoQCkPD5QD73uUOcFTTYQVtQHQCFScLxJJirFCwCW8bDfWAYHPXhmpZvTWEFj3eIDndlwfgEy0vEU30TsTN0PuW9NDA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NSWA7BgP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GMd0Q0yw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NSWA7BgP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GMd0Q0yw" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 647BxZX62734072 for ; Thu, 7 May 2026 14:48:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DKXU0I6LMH/BMCj9EeRl1cnpVQr3dSMcJSJRMFTrF9M=; b=NSWA7BgPgkyxZqm5 9/yjPKr19EdktGHjzpulRC8gXOTgu5o4o5Og3iJPp3IQDycJCdTQAXsMPwkdj+Fy eIqK3cbrvmW7VKTCC7BxNH40BefUhXMjp8kz1zI/mdaJc3AnszyxElK6D9GT3Y47 Bmo0MWn0Bkuhn3ue64sz6QxUCv3TZFWaLWvHhc/Y/i7JYr+y9PLACAQFVSUzPc/W MUmD9JF1n8FTnov7EI2QsEZ7i1eSVYBYjetCuVmS/IpaIQq0VNSii1DmQBmN4ugO HPy43xDbIAZeOQnpqpCrtjb6Li+l47fK0TDNA3Kb+imSbYeWkC48UhsgWDRHRWLd yJahuA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0tbqrn8h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 14:48:09 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b4530a90fdso23372215ad.1 for ; Thu, 07 May 2026 07:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778165289; x=1778770089; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DKXU0I6LMH/BMCj9EeRl1cnpVQr3dSMcJSJRMFTrF9M=; b=GMd0Q0ywIb2Z+isRHLg9IVEtSrxZ5+TUPhsRIwtLby2iHDlDfA7w0yF+ikilCOosDG nK6CZ1J/+piq1F5NRJAXscx7jmQ7OEVKY6uuKWrcfqGZONLVBRrHk1TmKe5bFl+j1U/Q 99vkNFG8xJLATnmj4a4O58c5nveocXpALVXA1rt7YtjgabVwJmjfpFJ5qMpnxrkbFfOr /d2bd8eOdbQzEsnVrgqtSakwQ96l/P39vBgxDKwNv7Ux0+3B+7oefWRtgE1xpl9gEC2P PxGLNIRWtCl/o1g+a7gOVtt5qgRBq/tTqLyT/CI6eF/wPm2Cfb7+dWI1ryX3DhQ/GpJd Lkdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778165289; x=1778770089; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DKXU0I6LMH/BMCj9EeRl1cnpVQr3dSMcJSJRMFTrF9M=; b=qNnKRNG2ExZLyVo77vf7kpFvAXJDTrZ8+Bpcy1BxZhxxKsCWVYPza+1ST/T2mi4HMg GR7THnAQCu8PDLSlAnZO3zdNkm/7DTVrB84GUkfOjmk6VFlUiB5Nfn6YJZvafJ/Z7fsg wspbPUmgRLF2h5VzDN5XeIt5UjuuM4Jnn3kabMlaInqFcL2n1R0gGOxksc3moSTWtyby jYQ7EUHl7FGCEl5RyxWrPhUsGRVM4doGDCgiqytwbOPjNmXKVAfbmUtqiLz8vW/S61jp kYlfABOnN94trFfc3PNjdx8Kk3xnZB5AgfLQmnSDpHuIoDtGrlyJmTGjszBkLB5AZtKU M4dQ== X-Forwarded-Encrypted: i=1; AFNElJ8hlraMm6Z2sJh+EFLnwV+9i0KxKq9RdajaxU41jGCPtAnr1ojXFhOCekObljhNteWuTZjQW1BNPEngvak=@vger.kernel.org X-Gm-Message-State: AOJu0YyCYjGMMknGThYUpkkYpct39myzU8DelVMe0aPMTCuJHic/CfcN ykw03hsKQj25JI4KLxuM0UyAkPDzddNG7HTb+TfoPT+TzKNNiWNwSo+wwg4lmpd0ER44xOPu486 KdnLv3o2xj0TV3JRpwNrdcsjXQW1PvBXVrCqHUf6EqfzchxCwYAthPki92wr3p7Fg9lo= X-Gm-Gg: AeBDieu7PZS+SgMTBnUmHIbvz/h354cuAow/6ngvjMF+10m2wpL/UYUJF4hLOTk7j7V YOvsneNA5LMGL+mdV30MHNScOTs+QR/LckFOJrFl7hF59u/F9E2X28bjVlKVWsKfrgs/cmb5+ia D37aZt2YuTUJcN8kKmU8j1R2tgzfzqhjG/6nixN1E88v6IcTxjvoyQz34qxeSDjY45mgy2bFtI4 sGw8Y0M5j4174fbSgUdxBlay2yAT38NDC1M4abeEMJAi8Oj6avEk426+HVreZhRuuQ34nP6+xUL KqMaqxMZcZsJ+4u9buWCS6I0MS0t1FSWHGPDqRz4IvFN9w7wLd6BeWkfqAz65gF2VteB3rn1qB8 H2DJLzabmYcEa39fGLHTx6W/ckfIxajwS/KcfN3d9ZK1vx4ePusjYEIk0icooM5sp1w== X-Received: by 2002:a17:903:1ab0:b0:2b2:4bf9:1766 with SMTP id d9443c01a7336-2ba7a34b378mr93506255ad.33.1778165289010; Thu, 07 May 2026 07:48:09 -0700 (PDT) X-Received: by 2002:a17:903:1ab0:b0:2b2:4bf9:1766 with SMTP id d9443c01a7336-2ba7a34b378mr93505935ad.33.1778165288547; Thu, 07 May 2026 07:48:08 -0700 (PDT) Received: from [10.206.103.12] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2babaaed237sm27158205ad.27.2026.05.07.07.48.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 07:48:08 -0700 (PDT) Message-ID: <6ea04749-d432-486a-b04e-46adaa9d0666@oss.qualcomm.com> Date: Thu, 7 May 2026 20:18:01 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 18/29] drm/msm/adreno: use new helper to set amsbc To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-ubwc-rework-v4-0-c19593d20c1d@oss.qualcomm.com> <20260507-ubwc-rework-v4-18-c19593d20c1d@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <20260507-ubwc-rework-v4-18-c19593d20c1d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: XiVtQglvvvuz96acmgixTR74Sc5fOGSS X-Authority-Analysis: v=2.4 cv=SJVykuvH c=1 sm=1 tr=0 ts=69fca629 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=BTchm6ImzknZz8NDhdQA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: XiVtQglvvvuz96acmgixTR74Sc5fOGSS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDE0OCBTYWx0ZWRfX3jnKI1/FwItL 09X6UcuNM2JiiKMj8TktltOWb4widR7Yg31pCvoLnMWjgBtfFEToWS8ZhUU/Ji+/2eUz0PCppkY u355eHUBRSlSPBaaVd91E9UQaS8luKRtr1MearikmmyQZYC8xgDTCkLfIK6e+aDReBAnTo7BpQw OYUcSPkKs88KxAVg1kfagAamRoJQm8c9dSFY0G2f6ISK5Kq9mvd+NhmXl+yY93O5Rim5iAMwvjj 8W7A2K7lBaVLOhOYA1vBFsImr3yXIWxOiBYZZYP226eI+SDQfdsdOhC9ZuJBgvLwIpS++EyNg98 b/B9xamCaSfU/t9+yVGaI/GLP8ZsSCma7P7+TYz+dczSqhHqEl3tvptSIv1jk7uLavLHRmuEU2n NAEexGOl9J4xJlcWgjHRcdZnnziituJInYvi/VJ60hbQnyjO0jsl1jdJfCqybkUeszDbzsjw5Hj ofBPW1EaHxP0BAlGY0g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-07_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070148 On 5/7/2026 6:33 PM, Dmitry Baryshkov wrote: > Use freshly defined helper instead of checking the UBWC version > directly. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Akhil P Oommen -Akhil > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- > drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 7 ++----- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index 5c17565b0499..a88489bdad9a 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -747,7 +747,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) > bool rgb565_predicator = cfg->ubwc_enc_version >= UBWC_4_0; > u32 level2_swizzling_dis = !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENABLE_LVL2); > bool ubwc_mode = qcom_ubwc_get_ubwc_mode(cfg); > - bool amsbc = cfg->ubwc_enc_version >= UBWC_3_0; > + bool amsbc = qcom_ubwc_enable_amsbc(cfg); > bool min_acc_len_64b; > u8 uavflagprd_inv = 0; > u32 hbb_hi = hbb >> 2; > diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > index 867c7d05f670..5c73a9ebb22b 100644 > --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c > @@ -279,7 +279,8 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) > u32 level3_swizzling_dis = !(qcom_ubwc_swizzle(cfg) & UBWC_SWIZZLE_ENABLE_LVL3); > bool rgba8888_lossless = false, fp16compoptdis = false; > bool yuvnotcomptofc = false, min_acc_len_64b = false; > - bool rgb565_predicator = false, amsbc = false; > + bool rgb565_predicator = false; > + bool amsbc = qcom_ubwc_enable_amsbc(cfg); > bool ubwc_mode = qcom_ubwc_get_ubwc_mode(cfg); > u32 ubwc_version = cfg->ubwc_enc_version; > u32 hbb, hbb_hi, hbb_lo, mode; > @@ -288,21 +289,17 @@ static void a8xx_set_ubwc_config(struct msm_gpu *gpu) > switch (ubwc_version) { > case UBWC_6_0: > yuvnotcomptofc = true; > - amsbc = true; > rgb565_predicator = true; > break; > case UBWC_5_0: > - amsbc = true; > rgb565_predicator = true; > break; > case UBWC_4_0: > - amsbc = true; > rgb565_predicator = true; > fp16compoptdis = true; > rgba8888_lossless = true; > break; > case UBWC_3_0: > - amsbc = true; > fp16compoptdis = true; > break; > default: >