* [PATCH] tc-testing: flush gact actions on test teardown
@ 2018-05-18 16:21 Vlad Buslov
2018-05-22 15:43 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Vlad Buslov @ 2018-05-18 16:21 UTC (permalink / raw)
To: linux-kselftest; +Cc: shuah, davem, lucasb, jhs, mrv, linux-kernel, Vlad Buslov
Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
on teardown. Leaking pipe action causes failures in other tests.
Add additional teardown command to also flush gact actions.
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
---
tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
index 443c9b3..acb24f7 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
@@ -44,7 +44,8 @@
"matchPattern": "action order [0-9]*: mirred \\(Egress Redirect to device lo\\).*index 2 ref",
"matchCount": "1",
"teardown": [
- "$TC actions flush action mirred"
+ "$TC actions flush action mirred",
+ "$TC actions flush action gact"
]
},
{
--
2.7.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tc-testing: flush gact actions on test teardown
2018-05-18 16:21 [PATCH] tc-testing: flush gact actions on test teardown Vlad Buslov
@ 2018-05-22 15:43 ` Shuah Khan
2018-05-22 15:49 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2018-05-22 15:43 UTC (permalink / raw)
To: Vlad Buslov, linux-kselftest, davem
Cc: lucasb, jhs, mrv, linux-kernel, Shuah Khan
On 05/18/2018 10:21 AM, Vlad Buslov wrote:
> Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
> on teardown. Leaking pipe action causes failures in other tests.
>
> Add additional teardown command to also flush gact actions.
>
> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
> ---
> tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
> index 443c9b3..acb24f7 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
> @@ -44,7 +44,8 @@
> "matchPattern": "action order [0-9]*: mirred \\(Egress Redirect to device lo\\).*index 2 ref",
> "matchCount": "1",
> "teardown": [
> - "$TC actions flush action mirred"
> + "$TC actions flush action mirred",
> + "$TC actions flush action gact"
> ]
> },
> {
>
I can get this into 4.18-rc1 unless there is a reason for this to go
through net tree.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tc-testing: flush gact actions on test teardown
2018-05-22 15:43 ` Shuah Khan
@ 2018-05-22 15:49 ` David Miller
2018-05-22 16:10 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2018-05-22 15:49 UTC (permalink / raw)
To: shuah; +Cc: vladbu, linux-kselftest, lucasb, jhs, mrv, linux-kernel
From: Shuah Khan <shuah@kernel.org>
Date: Tue, 22 May 2018 09:43:28 -0600
> On 05/18/2018 10:21 AM, Vlad Buslov wrote:
>> Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
>> on teardown. Leaking pipe action causes failures in other tests.
>>
>> Add additional teardown command to also flush gact actions.
>>
>> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
>> ---
>> tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>> index 443c9b3..acb24f7 100644
>> --- a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>> +++ b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>> @@ -44,7 +44,8 @@
>> "matchPattern": "action order [0-9]*: mirred \\(Egress Redirect to device lo\\).*index 2 ref",
>> "matchCount": "1",
>> "teardown": [
>> - "$TC actions flush action mirred"
>> + "$TC actions flush action mirred",
>> + "$TC actions flush action gact"
>> ]
>> },
>> {
>>
>
> I can get this into 4.18-rc1 unless there is a reason for this to go
> through net tree.
Why wouldn't a networking testing bug fix go through my tree?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tc-testing: flush gact actions on test teardown
2018-05-22 15:49 ` David Miller
@ 2018-05-22 16:10 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2018-05-22 16:10 UTC (permalink / raw)
To: David Miller
Cc: vladbu, linux-kselftest, lucasb, jhs, mrv, linux-kernel,
Shuah Khan
On 05/22/2018 09:49 AM, David Miller wrote:
> From: Shuah Khan <shuah@kernel.org>
> Date: Tue, 22 May 2018 09:43:28 -0600
>
>> On 05/18/2018 10:21 AM, Vlad Buslov wrote:
>>> Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
>>> on teardown. Leaking pipe action causes failures in other tests.
>>>
>>> Add additional teardown command to also flush gact actions.
>>>
>>> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
>>> ---
>>> tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>>> index 443c9b3..acb24f7 100644
>>> --- a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>>> +++ b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>>> @@ -44,7 +44,8 @@
>>> "matchPattern": "action order [0-9]*: mirred \\(Egress Redirect to device lo\\).*index 2 ref",
>>> "matchCount": "1",
>>> "teardown": [
>>> - "$TC actions flush action mirred"
>>> + "$TC actions flush action mirred",
>>> + "$TC actions flush action gact"
>>> ]
>>> },
>>> {
>>>
>>
>> I can get this into 4.18-rc1 unless there is a reason for this to go
>> through net tree.
>
> Why wouldn't a networking testing bug fix go through my tree?
>
I usually take the selftest patches unless there is dependency on another
tree. I am fine with it going through net tree
Acked-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-22 16:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-18 16:21 [PATCH] tc-testing: flush gact actions on test teardown Vlad Buslov
2018-05-22 15:43 ` Shuah Khan
2018-05-22 15:49 ` David Miller
2018-05-22 16:10 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox