From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings
Date: Tue, 18 Feb 2020 23:42:41 +0530 [thread overview]
Message-ID: <6ea1e6a5-4942-5dba-4e91-28275db00153@codeaurora.org> (raw)
In-Reply-To: <20200130180637.9E02D206F0@mail.kernel.org>
Thanks Stephen.
Will address the comments in the next patch series.
On 1/30/2020 11:36 PM, Stephen Boyd wrote:
> Quoting Taniya Das (2020-01-29 20:18:41)
>> The Modem Subsystem clock provider have a bunch of generic properties
>> that are needed in a device tree. Add a YAML schemas for those.
>>
>> Signed-off-by: Taniya Das <tdas@codeaurora.org>
>> ---
>> .../devicetree/bindings/clock/qcom,mss.yaml | 58 ++++++++++++++++++++++
>
> Please rename to qcom,sc7180-mss.yaml
>
>> 1 file changed, 58 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,mss.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,mss.yaml b/Documentation/devicetree/bindings/clock/qcom,mss.yaml
>> new file mode 100644
>> index 0000000..ebb04e1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,mss.yaml
>> @@ -0,0 +1,58 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/bindings/clock/qcom,mss.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Modem Clock Controller Binding
>> +
>> +maintainers:
>> + - Taniya Das <tdas@codeaurora.org>
>> +
>> +description: |
>> + Qualcomm modem clock control module which supports the clocks.
>
> Can you point to the header file from here?
> include/dt-bindings/clock/qcom,sc7180-mss.h I guess.
>
will add the same.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,sc7180-mss
>> +
>> + clocks:
>> + minItems: 1
>> + maxItems: 3
>
> Why is it optional? Don't these all go there?
>
Yes, moved them to required.
>> + items:
>> + - description: gcc_mss_mfab_axi clock from GCC
>> + - description: gcc_mss_nav_axi clock from GCC
>> + - description: gcc_mss_cfg_ahb clock from GCC
>> +
>> + clock-names:
>> + items:
>> + - const: gcc_mss_mfab_axis_clk
>> + - const: gcc_mss_nav_axi_clk
>> + - const: cfg_clk
>
> Do these really need _clk at the end? Seems redundant.
>
Removed _clk.
>> +
>> + '#clock-cells':
>> + const: 1
>> +
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
next prev parent reply other threads:[~2020-02-18 18:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 4:18 [PATCH v3 0/3] Add modem Clock controller (MSS CC) driver for SC7180 Taniya Das
2020-01-30 4:18 ` [PATCH v3 1/3] dt-bindings: clock: Add YAML schemas for the QCOM MSS clock bindings Taniya Das
2020-01-30 18:06 ` Stephen Boyd
2020-02-18 18:12 ` Taniya Das [this message]
2020-02-07 7:27 ` Sibi Sankar
2020-02-07 10:27 ` Taniya Das
2020-01-30 4:18 ` [PATCH v3 2/3] dt-bindings: clock: Introduce QCOM Modem " Taniya Das
2020-01-30 18:09 ` Stephen Boyd
2020-02-18 18:21 ` Taniya Das
2020-01-30 4:18 ` [PATCH v3 3/3] clk: qcom: Add modem clock controller driver for SC7180 Taniya Das
2020-01-30 18:08 ` Stephen Boyd
2020-02-18 18:22 ` Taniya Das
2020-02-07 7:24 ` [PATCH v3 0/3] Add modem Clock controller (MSS CC) " Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ea1e6a5-4942-5dba-4e91-28275db00153@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox