From: Jiri Slaby <jirislaby@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 2/2] tty: serial: samsung_tty: cast the interrupt's void *id just once
Date: Thu, 8 Aug 2024 10:35:26 +0200 [thread overview]
Message-ID: <6ea8f8fd-97b8-4c47-b042-cb8d64efebad@kernel.org> (raw)
In-Reply-To: <20240808-samsung-tty-cleanup-v3-2-494412f49f4b@linaro.org>
On 08. 08. 24, 10:11, André Draszik wrote:
> The interrupt handler routines and helpers are casting the 'void *'
> pointer to 'struct exynos_uart_port *' all over the place.
>
> There is no need for that, we can do the casting once and keep passing
> the 'struct exynos_uart_port *', simplifying the code and saving a few
> lines of code.
>
> No functional changes.
>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> v3: undo too eager removal of 'const' where unnecessary (Jiri)
LGTM now
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> v2: fix -Wdiscarded-qualifiers, sorry
thanks,
--
js
suse labs
prev parent reply other threads:[~2024-08-08 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 8:11 [PATCH v3 0/2] tty: serial: samsung_tty: simple cleanups André Draszik
2024-08-08 8:11 ` [PATCH v3 1/2] tty: serial: samsung_tty: drop unused argument to irq handlers André Draszik
2024-08-08 8:34 ` Jiri Slaby
2024-08-08 8:11 ` [PATCH v3 2/2] tty: serial: samsung_tty: cast the interrupt's void *id just once André Draszik
2024-08-08 8:35 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ea8f8fd-97b8-4c47-b042-cb8d64efebad@kernel.org \
--to=jirislaby@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox