From: Johannes Berg <johannes@sipsolutions.net>
To: "Adrián García Casado" <adriangarciacasado42@gmail.com>,
"Miri Korenblit" <miriam.rachel.korenblit@intel.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [PATCH v4] wifi: iwlwifi: pcie: optimize MSI-X interrupt affinity
Date: Wed, 18 Mar 2026 08:52:57 +0100 [thread overview]
Message-ID: <6eb04d4729c562ffebd29e34c83be63996c886ea.camel@sipsolutions.net> (raw)
In-Reply-To: <20260317193252.13763-1-adriangarciacasado42@gmail.com>
On Tue, 2026-03-17 at 20:32 +0100, Adrián García Casado wrote:
> Balanced distribution: skip CPU0 for high-rate RSS queues to avoid contention with system housekeeping. Use a stateful last_cpu approach to ensure unique core assignment when skipping CPU0. This avoids mapping multiple queues to the same core.
You need to break lines ...
I tend to think you need a better reason to skip CPU0. Last time you
pretended it was actually going to be faster, now you pretend there's
contention, without ever really getting to any proof of that?
Also please read what I said before:
>> this is wrong since you really then should allocate one queue less,
>> rather than mapping two queues to the same core.
johannes
next prev parent reply other threads:[~2026-03-18 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 19:32 [PATCH v4] wifi: iwlwifi: pcie: optimize MSI-X interrupt affinity Adrián García Casado
2026-03-18 7:52 ` Johannes Berg [this message]
2026-03-18 13:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb04d4729c562ffebd29e34c83be63996c886ea.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=adriangarciacasado42@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox