From: Justin Lai <justinlai0215@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next v3 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code
Date: Fri, 18 Aug 2023 06:44:25 +0000 [thread overview]
Message-ID: <6eb491dbf89f443dafbff0a9f6353914@realtek.com> (raw)
In-Reply-To: <20230817085314.1c8b567f@kernel.org>
> On Tue, 15 Aug 2023 22:37:55 +0800 Justin Lai wrote:
> > .../net/ethernet/realtek/rtase/rtase_main.c | 2696 +++++++++++++++++
> > 5 files changed, 3127 insertions(+)
>
> Please try to make this patch smaller, usually breaking out ethtool operations
> and any offloads to separate patches does the trick.
> Keep in mind the driver must be operational after each patch.
Thank you for your review, I will make this change in version 5.
next prev parent reply other threads:[~2023-08-18 6:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 14:37 [PATCH net-next v3 0/2] Add Realtek automotive PCIe driver Justin Lai
2023-08-15 14:37 ` [PATCH net-next v3 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code Justin Lai
2023-08-15 15:33 ` Andrew Lunn
2023-08-17 7:32 ` Justin Lai
2023-08-17 12:22 ` Andrew Lunn
2023-08-18 11:56 ` Justin Lai
2023-08-18 12:16 ` Andrew Lunn
2023-08-21 5:31 ` Justin Lai
2023-08-21 13:12 ` Andrew Lunn
2023-08-21 15:07 ` Justin Lai
2023-08-21 17:21 ` Andrew Lunn
2023-08-22 3:26 ` Justin Lai
2023-08-17 15:53 ` Jakub Kicinski
2023-08-18 6:44 ` Justin Lai [this message]
2023-08-15 14:37 ` [PATCH net-next v3 2/2] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb491dbf89f443dafbff0a9f6353914@realtek.com \
--to=justinlai0215@realtek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox