From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4EA932DB7AC for ; Fri, 23 Jan 2026 10:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769163956; cv=none; b=e4xv3lp3AIHGkK5zq7aPLw7qWzEV93xa5p8MdPZpa/0EYhxee/mAAMCztkZQHUVqOWu4z3OXZ14TRd4r9ZFFSTf2c8gWvIokwRAvefs1mIsejUpDBjrcNoGudbH4ze71vLtXpxJFn30z16M5Qb92S0qfh5ZU00FQLzGN52LvQII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769163956; c=relaxed/simple; bh=17Pr6AYsOQnJhPQYTcZIfO0E3LPLBC4d5Bcr2kncSC8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cYiK/GLGU3HhyU7RSISJ1KJ41g8rfvDH/fKTxZft2BHiNM3d2GF36r99M++XeC0kBPAYqkpFf1hVpRdfav7DVpQUetEZTdWsktemXgKCak/bamRfQ471hrzUkmq8KfYupsJjL2TIVa+r0fd7B7HfyZc9c5WWW/v6Cdp1H8/Ryc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF7E01476; Fri, 23 Jan 2026 02:25:42 -0800 (PST) Received: from [10.164.136.38] (unknown [10.164.136.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 320003F740; Fri, 23 Jan 2026 02:25:45 -0800 (PST) Message-ID: <6ed1e12d-ebd1-4627-a6fd-ad72f1c68fee@arm.com> Date: Fri, 23 Jan 2026 15:55:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-new v5 1/5] mm: khugepaged: add trace_mm_khugepaged_scan event To: Vernon Yang , akpm@linux-foundation.org, david@kernel.org Cc: lorenzo.stoakes@oracle.com, ziy@nvidia.com, baohua@kernel.org, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vernon Yang References: <20260123082232.16413-1-vernon2gm@gmail.com> <20260123082232.16413-2-vernon2gm@gmail.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20260123082232.16413-2-vernon2gm@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/01/26 1:52 pm, Vernon Yang wrote: > From: Vernon Yang > > Add mm_khugepaged_scan event to track the total time for full scan > and the total number of pages scanned of khugepaged. > > Signed-off-by: Vernon Yang > Acked-by: David Hildenbrand (Red Hat) > Reviewed-by: Barry Song > Reviewed-by: Lance Yang Reviewed-by: Dev Jain > --- > include/trace/events/huge_memory.h | 25 +++++++++++++++++++++++++ > mm/khugepaged.c | 2 ++ > 2 files changed, 27 insertions(+) > > diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h > index 4e41bff31888..384e29f6bef0 100644 > --- a/include/trace/events/huge_memory.h > +++ b/include/trace/events/huge_memory.h > @@ -237,5 +237,30 @@ TRACE_EVENT(mm_khugepaged_collapse_file, > __print_symbolic(__entry->result, SCAN_STATUS)) > ); > > +TRACE_EVENT(mm_khugepaged_scan, > + > + TP_PROTO(struct mm_struct *mm, unsigned int progress, > + bool full_scan_finished), > + > + TP_ARGS(mm, progress, full_scan_finished), > + > + TP_STRUCT__entry( > + __field(struct mm_struct *, mm) > + __field(unsigned int, progress) > + __field(bool, full_scan_finished) > + ), > + > + TP_fast_assign( > + __entry->mm = mm; > + __entry->progress = progress; > + __entry->full_scan_finished = full_scan_finished; > + ), > + > + TP_printk("mm=%p, progress=%u, full_scan_finished=%d", > + __entry->mm, > + __entry->progress, > + __entry->full_scan_finished) > +); > + > #endif /* __HUGE_MEMORY_H */ > #include > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index e76f42243534..6f0f05148765 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2535,6 +2535,8 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, enum scan_result > collect_mm_slot(slot); > } > > + trace_mm_khugepaged_scan(mm, progress, khugepaged_scan.mm_slot == NULL); > + > return progress; > } >