From: Guo Samin <samin.guo@starfivetech.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<netdev@vger.kernel.org>, Peter Geis <pgwipeout@gmail.com>,
Frank <Frank.Sae@motor-comm.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>, Conor Dooley <conor@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Yanhong Wang <yanhong.wang@starfivetech.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg
Date: Mon, 17 Jul 2023 16:28:55 +0800 [thread overview]
Message-ID: <6ed58545-c10a-d789-04d5-4eb715f4906d@starfivetech.com> (raw)
In-Reply-To: <4efd8643-455e-4f7f-b031-a0a02dd65210@lunn.ch>
-------- 原始信息 --------
主题: Re: [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg
From: Andrew Lunn <andrew@lunn.ch>
收件人: Samin Guo <samin.guo@starfivetech.com>
日期: 2023/7/15
>> + motorcomm,rx-clk-driver-strength:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: |
>> + drive strength of rx_clk rgmii pad.
>> + |----------------------------------|
>> + | rx_clk ds map table |
>> + |----------------------------------|
>> + | DS(3b) | wol@1.8v | wol@3.3v |
>> + |________|_________________________|
>> + | | current(uA)| current(uA)|
>> + | 000 | 1200 | 3070 |
>> + | 001 | 2100 | 4080 |
>> + | 010 | 2700 | 4370 |
>> + | 011 | 2910 | 4680 |
>> + | 100 | 3110 | 5020 |
>> + | 101 | 3600 | 5450 |
>> + | 110 | 3970 | 5740 |
>> + | 111 | 4350 | 6140 |
>> + |--------|------------|------------|
>> + enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970,
>> + 4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ]
>> + default: 2910
>
> The DS(3b) value is not relevant to the binding. It is a driver
> detail. So i would not bother listing it.
>
ok， will remove it.
> Please add a comment explaining what wol is.
>
> Andrew
Sorry，it should be vol (voltage), not wol.
Best regards,
Samin
next prev parent reply other threads:[~2023-07-17 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 10:14 [PATCH v4 0/2] Add motorcomm phy pad-driver-strength-cfg support Samin Guo
2023-07-14 10:14 ` [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg Samin Guo
2023-07-14 18:54 ` Andrew Lunn
2023-07-17 8:28 ` Guo Samin [this message]
2023-07-15 2:47 ` Rob Herring
2023-07-17 8:35 ` Guo Samin
2023-07-14 10:14 ` [PATCH v4 2/2] net: phy: motorcomm: Add pad drive strength cfg support Samin Guo
2023-07-14 18:49 ` Andrew Lunn
2023-07-17 8:40 ` Guo Samin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ed58545-c10a-d789-04d5-4eb715f4906d@starfivetech.com \
--to=samin.guo@starfivetech.com \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox