Re: [PATCH 1/2] drm: introduce page_flip_timeout()

["Michel Dänzer" <michel.daenzer@mailbox.org>]

On 1/28/26 15:25, Michel Dänzer wrote:
> On 1/28/26 13:48, Christian König wrote:
>> On 1/28/26 13:14, Timur Kristóf wrote:
>>> On Wednesday, January 28, 2026 12:26:20 PM Central European Standard Time 
>>> Michel Dänzer wrote:
>>>> On 1/28/26 11:39, Christian König wrote:
>>>>>
>>>>> Even if we missed a vblank interrupt that thing is reoccurring, so the
>>>>> worst thing that can happen is that we delayed reporting back success by
>>>>> one frame.
>>>>>
>>>>> So something must have turned the CRTC fully off.
>>>>
>>>> Not sure that's a generally valid conclusion (do the gitlab issues talk
>>>> about the display going black, or about it staying on but freezing?).
>>>
>>> In all the bug reports I've seen about page flip timeouts, and in all the 
>>> timeouts I've seen on my machine, the screen remains on, but frozen.
>>> It doesn't go black and doesn't turn off.
>>>
>>> Christian, why would the CRTC be turned off?
>>
>> Exactly that's the question we need to answer.
>>
>> But from what you describe the CRTC keeps on, just doesn't send any more vblank events.
> 
> The vblank interrupt source getting accidentally disabled might be one possible cause though.

Another possibility is that test-only commits with the DRM_MODE_ATOMIC_TEST_ONLY flag (which can happen in parallel while the kernel is processing a "real" commit) accidentally have side effects on the current kernel state, resulting in the "real" commit failing to do something it should. There have been bugs like that in the amdgpu DM code before.


Anyway, this is all speculation. Somebody just needs to dig in and get to the bottom of why the commits aren't getting completed.


-- 
Earthling Michel Dänzer       \        GNOME / Xwayland / Mesa developer
https://redhat.com             \               Libre software enthusiast