From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4BB87080E for ; Fri, 14 Mar 2025 16:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741970784; cv=none; b=ad3GEl/J9k0V8K86okEusAc7F9zAvIGjOfmD68lNUPZgqIJRY78KrLSPiQzvK9BdCFqz0Xj96qrod8FlPrNX5F5A4NmlG5LJQbLC7plZaKi1AfzBuC1yG634/v5kkWh/YJSF2rxpzVp6cs0mS4b2Miqwx9qmGSR1NKCTfC0vnxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741970784; c=relaxed/simple; bh=9yVvwFZwWIIwJ4cqVDKRbVbSDXWcXfSzB4OeZg+iobs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O4Mm5wlBYfz2hhuJAYfq1ZUIjDf5eKMa2avW5VRMHZKrpne5Slfg8+OF2vDmXy8g6NiOYAOukf5Gzy9WCiTWVJIpl2RvvUNmvFNcNQUl0t4MOhVpMM4ld3/FCLh4S4mzu4lU9KszOBcCbkJcGXQ45oPSUdZzIufSIkd1twfwSRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MkPq5kWO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MkPq5kWO" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52EAPLjZ020021 for ; Fri, 14 Mar 2025 16:46:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V7iC8xf8rHfTJsz/B/gMbvSBnsp1N8NKxvrp+AGSFII=; b=MkPq5kWOire3LWlq RT44WTSZDdVihrF+mPzUf5Z9m1Thxg2Id2PcfOWB+zZmDKtDdZNO8+A/z78HV+Fz m1tKZVwv1OSj7RS2PW9FdJQ2LREfLbuICM6x2rNdwf8ZWqVxGH4PnLxscDCKonad s64MQG8ZyPKCjBciqhhawp5zOth5s6/THmBMi0govnfu203H/5txQjCO780GA5SF PG6sm2ZTxgy6TAtZnIF5gyt3A6qfXQwiYWfoiWFYY1Rg6LsLrcXw2eXIRj2GUuPx Oom3n8+6N0i06YZxNf9Eg+SKWFsvjxlS/ua9L11Y76NtR8VGaot8UaJa/06T/HZ0 UbIK3w== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45cjph0x8e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 14 Mar 2025 16:46:21 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-223a2770b75so44940815ad.1 for ; Fri, 14 Mar 2025 09:46:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741970780; x=1742575580; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V7iC8xf8rHfTJsz/B/gMbvSBnsp1N8NKxvrp+AGSFII=; b=IytYCuBeagavblXnIAEWZjXLdax7XXBtz2L1e/xsC9YpSgcVG5czvBr8iVFRRwjyQh Z+cf9ulBUm/I+tkIV96M696VPTrbR+GTeAAYFMYfRDQ3AjJsndQ7Ipvl2reWCA+Z7xYm PH8fXI3YjONVsD1gZl/kN9XZKXicMuxr7TWs2OYKMbrmFe1wClS+fW3rRfx+JSk3xd6N od9Ws22QRvbXtBdhH6N4fPy7oEsRQAv5QWdp1i2nO7Z8o86BYFeW/SjL9yhLCnDVVm9R 4WLbw1H8id855zeiQwGCxG3oaFYVFDSU+50jdWOFNTKjHuRNK9ef0npQ2ebf0bnRHrak 9i5g== X-Forwarded-Encrypted: i=1; AJvYcCWjepfVremzDd4j3f3YaJWGm38ufCHJ7H/qFPH8Qgnn5s+imo1MsahtvENI7ke5ym/LfDRcjnuPj/EDA7w=@vger.kernel.org X-Gm-Message-State: AOJu0YxZtax+dq/sugpcuYj9uLbWdT5lZB+PX507jNz8jd3dyhskjDFH c1/sx0nj3/QB/EmhUugED53Co5ATZLpcirn4JKKUlwSBVXdDQoFkpxuhNYuqspB9PeAspkNpiXH zf9CyaQ34DDVAU9Bhp2V/DNQkxtyc4SpgFd7+apw2mcYSvDmfgAgdeUnkQpvkElA= X-Gm-Gg: ASbGnctQQHDIUrtlCohIDKI7DngveEL2j2HSlB8tqLz5R04OtAKEw47eAIEpYmZ97l0 PkXN5xUBH2d/U/k+xIonnbuEZqdekLHmsKLGwlVeVYmnFEz/xvd3R6pxrfvrvEobG/sIUWgizqa ipmFXHjED0DPGn/kpfRNrkBtpGYEOKF7SyfDMYsHdYkcM/rIf1VVBlSx8Y3HEzZx5q194SCn23v 0afCoFD3ykiplJyaHN7LntxxX1p9F7FgiZtfmo1y8IugDFrm7D+oTeI1DGn/hDfTVp0Rm2Q1PFZ FjjUzOQZeg8rZa9yGZoLTC7DuoauzP0q7MAhH3MpS34EYOQxQN/Hd+epvpeGnHajSA== X-Received: by 2002:aa7:88ca:0:b0:736:6279:ca25 with SMTP id d2e1a72fcca58-737223fd657mr4639689b3a.24.1741970780276; Fri, 14 Mar 2025 09:46:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5Z0N372C40vTLg+lf6IIyxYpGOfRFioICowlAofkGkUXQTNrit8/4263LMemsQpFAjwboYw== X-Received: by 2002:aa7:88ca:0:b0:736:6279:ca25 with SMTP id d2e1a72fcca58-737223fd657mr4639655b3a.24.1741970779865; Fri, 14 Mar 2025 09:46:19 -0700 (PDT) Received: from [10.226.59.182] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7371167d89asm3178677b3a.94.2025.03.14.09.46.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Mar 2025 09:46:19 -0700 (PDT) Message-ID: <6f53e1f6-3ac8-4828-9ef5-dbeb76ab1459@oss.qualcomm.com> Date: Fri, 14 Mar 2025 10:46:18 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] accel/qaic: Fix integer overflow in qaic_validate_req() To: Dan Carpenter Cc: Carl Vanderlip , Oded Gabbay , Jacek Lawrynowicz , Pranjal Ramajor Asha Kanojiya , Stanislaw Gruszka , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <176388fa-40fe-4cb4-9aeb-2c91c22130bd@stanley.mountain> Content-Language: en-US From: Jeff Hugo In-Reply-To: <176388fa-40fe-4cb4-9aeb-2c91c22130bd@stanley.mountain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=a7sw9VSF c=1 sm=1 tr=0 ts=67d45d5d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=LlO3PXAvtcZV46L7pkYA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: 5Nz_lxyKnM7Tt8egBQLyLFzmnvL6j4hm X-Proofpoint-ORIG-GUID: 5Nz_lxyKnM7Tt8egBQLyLFzmnvL6j4hm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-14_06,2025-03-14_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 impostorscore=0 mlxlogscore=848 priorityscore=1501 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503140131 On 3/7/2025 1:41 AM, Dan Carpenter wrote: > These are u64 variables that come from the user via > qaic_attach_slice_bo_ioctl(). Use check_add_overflow() to ensure that > the math doesn't have an integer wrapping bug. > > Cc: stable@vger.kernel.org > Fixes: ff13be830333 ("accel/qaic: Add datapath") > Signed-off-by: Dan Carpenter Thanks! Reviewed-by: Jeff Hugo